There is no check for the vendors_manage permission to render the New vendor button on the acquisitions homepage
Created attachment 173710 [details] [review] Bug 38297: Add a permissions check to the New vendor button Test plan: 1) Choose a staff patron and make sure they have permissions to log into the staff interface 2) Ensure that the patron does not have the vendors_manage permission but give them one other acquisitions permission so that they can see the link on the homepage (e.g. budget_manage) 3) In an incognito browser, log in with that patron and go to the acquisitions homepage 4) The New vendor button will be visible 5) Click on it and fill in the required fields. Submit the form and it will error for lack of permissions 6) Apply patch 7) Return to the acquisitions page and the New vendor button should no longer be visible 8) Back in your main browser, give the patron the vendors_manage permission and then refresh the incognito window - the button should be visible
Created attachment 173711 [details] [review] Bug 38297: Add a permissions check to the New vendor button Test plan: 1) Choose a staff patron and make sure they have permissions to log into the staff interface 2) Ensure that the patron does not have the vendors_manage permission but give them one other acquisitions permission so that they can see the link on the homepage (e.g. budget_manage) 3) In an incognito browser, log in with that patron and go to the acquisitions homepage 4) The New vendor button will be visible 5) Click on it and fill in the required fields. Submit the form and it will error for lack of permissions 6) Apply patch 7) Return to the acquisitions page and the New vendor button should no longer be visible 8) Back in your main browser, give the patron the vendors_manage permission and then refresh the incognito window - the button should be visible
Created attachment 173713 [details] [review] Bug 38297: Add a permissions check to the New vendor button Test plan: 1) Choose a staff patron and make sure they have permissions to log into the staff interface 2) Ensure that the patron does not have the vendors_manage permission but give them one other acquisitions permission so that they can see the link on the homepage (e.g. budget_manage) 3) In an incognito browser, log in with that patron and go to the acquisitions homepage 4) The New vendor button will be visible 5) Click on it and fill in the required fields. Submit the form and it will error for lack of permissions 6) Apply patch 7) Return to the acquisitions page and the New vendor button should no longer be visible 8) Back in your main browser, give the patron the vendors_manage permission and then refresh the incognito window - the button should be visible Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 173763 [details] [review] Bug 38297: Add a permissions check to the New vendor button Test plan: 1) Choose a staff patron and make sure they have permissions to log into the staff interface 2) Ensure that the patron does not have the vendors_manage permission but give them one other acquisitions permission so that they can see the link on the homepage (e.g. budget_manage) 3) In an incognito browser, log in with that patron and go to the acquisitions homepage 4) The New vendor button will be visible 5) Click on it and fill in the required fields. Submit the form and it will error for lack of permissions 6) Apply patch 7) Return to the acquisitions page and the New vendor button should no longer be visible 8) Back in your main browser, give the patron the vendors_manage permission and then refresh the incognito window - the button should be visible Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11
Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason.