To recreate: 1. Set copynumber in MarcItemFieldsToOrder: copyno: 965$z 2. Have a mrc file that includes this marc field 3. Stage a mrc file for import 4. Notice the copynumber isn't correctly copied over
Created attachment 173876 [details] [review] Bug 38326: Don't convert to copynumber To test: 1. Set copynumber in MarcItemFieldsToOrder: copyno: 965$z 2. Have a mrc file that includes this marc field 3. Stage a mrc file for import 4. Notice the copynumber isn't correctly copied over 5. APPLY PATCH, restart_all 6. Try again, this time it should work.
Created attachment 174287 [details] [review] Bug 38326: Don't convert to copynumber To test: 1. Set copynumber in MarcItemFieldsToOrder: copyno: 965$z 2. Have a mrc file that includes this marc field 3. Stage a mrc file for import 4. Notice the copynumber isn't correctly copied over 5. APPLY PATCH, restart_all 6. Try again, this time it should work. Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Created attachment 174678 [details] [review] Bug 38326: Don't convert to copynumber To test: 1. Set copynumber in MarcItemFieldsToOrder: copyno: 965$z 2. Have a mrc file that includes this marc field 3. Stage a mrc file for import 4. Notice the copynumber isn't correctly copied over 5. APPLY PATCH, restart_all 6. Try again, this time it should work. Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 174679 [details] [review] Bug 38326: (QA follow-up) Tidy Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Are we sure about this fix? # Handle incorrectly named original parameters for MarcItemFieldsToOrder $iteminfos->{location} = delete $iteminfos->{loc} if $iteminfos->{loc}; - $iteminfos->{copynumber} = delete $iteminfos->{copyno} if $iteminfos->{copyno}; @Nick can you maybe have a look? It just seems like this was intentionally added at some point. Maybe because the configuration should be using copynumber?
I think I added that line by mistake as the field in the items table is called 'copynumber' but in the template it is called 'copyno' so Lucas is correct to remove that line otherwise it doesn't render the value in the template and it won't then be passed into the ordering process. The logic for handling the ordering takes in the copyno values and then parses them to the correct 'copynumber' field when creating the items and the orderlines
I was missing some kind of explanation :) Thanks for that, Matt!
Pushed for 24.11! Well done everyone, thank you!
Is it possible to backport this to 24.05?
No Koha/MarcOrder.pm in 24.05.x, so no backport.