Bug 38351 - Improve layout of course reserve details
Summary: Improve layout of course reserve details
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords: additional_work_needed
Depends on:
Blocks:
 
Reported: 2024-11-04 17:40 UTC by Owen Leonard
Modified: 2025-03-07 20:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement improves the layout of course reserves pages. For the list of courses, it changes the "Reserves" heading to "Courses". For the course details page it: - Replaces the "Reserves" heading with the course name, matching the breadcrumbs and page title. - Adds separator lines between fields. - Adds colons after labels. - Fixes some alignment issues. - Only displays fields with values. - Now shows "0" for the "Number of students" if no value is added.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38351: Improve layout of course reserve details (6.93 KB, patch)
2024-11-04 18:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Screenshot - Course details page(showing formatting issues) (68.51 KB, image/png)
2025-01-03 01:02 UTC, David Nind
Details
Bug 38351: (follow-up) Tweaks to list and form alignment (3.57 KB, patch)
2025-01-10 19:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38351: Improve layout of course reserve details (6.98 KB, patch)
2025-01-10 20:25 UTC, David Nind
Details | Diff | Splinter Review
Bug 38351: (follow-up) Tweaks to list and form alignment (3.62 KB, patch)
2025-01-10 20:25 UTC, David Nind
Details | Diff | Splinter Review
Bug 38351: (follow-up) Tweaks to list and form alignment (3.68 KB, patch)
2025-01-10 20:42 UTC, William Lavoie
Details | Diff | Splinter Review
Bug 38351: Improve layout of course reserve details (6.60 KB, patch)
2025-02-12 14:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38351: (follow-up) Tweaks to list and form alignment (3.56 KB, patch)
2025-02-12 14:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38351: Improve layout of course reserve details (6.69 KB, patch)
2025-03-07 10:21 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 38351: (follow-up) Tweaks to list and form alignment (3.65 KB, patch)
2025-03-07 10:21 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-11-04 17:40:56 UTC
The course reserves detail page has a section showing details about the course. It could use some formatting improvements.
Comment 1 Owen Leonard 2024-11-04 18:10:16 UTC
Created attachment 173942 [details] [review]
Bug 38351: Improve layout of course reserve details

This patch makes some simple markup and CSS changes to the course
details page in order to improve the layout of the section:
- Add colons after labels.
- Replace fieldset.rows with div.rows (there's no form).
- Make list of instructors line up with other details.
- Do not display fields which are empty.

ALSO: Replaced the "Reserves" heading with course name, matching
breadcrumbs and page title.

To test, apply the patch and go to Course reserves.

- If necessary, create a course.
- View the details of the course.
- Confirm that the list of details looks correct.
  - Test with all the optional fields empty: Section, term, instructor,
    staff note, public note. There should not be empty lines for these
    fields in the course details.
  - "Number of students" should show "0" if you left the field empty.
- Add multiple instructors to confirm that they are displayed in
  alignment with other course details.
- The page heading should match the page breadcrumb.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2025-01-03 01:02:39 UTC
Created attachment 176109 [details]
Screenshot - Course details page(showing formatting issues)

Hi Owen.

This is a great improvement!

However, some things I noticed:

1. There is a row border just above/through the instructors row. (See screenshot.)
2. The staff note and public note are misaligned. (See screenshot.)
3. When editing the course, the instructor search label and search box are indented/misaligned, unless that is the way it is supposed to be. 

David
Comment 3 Owen Leonard 2025-01-10 19:50:36 UTC
Created attachment 176389 [details] [review]
Bug 38351: (follow-up) Tweaks to list and form alignment
Comment 4 David Nind 2025-01-10 20:25:43 UTC
Created attachment 176394 [details] [review]
Bug 38351: Improve layout of course reserve details

This patch makes some simple markup and CSS changes to the course
details page in order to improve the layout of the section:
- Add colons after labels.
- Replace fieldset.rows with div.rows (there's no form).
- Make list of instructors line up with other details.
- Do not display fields which are empty.

ALSO: Replaced the "Reserves" heading with course name, matching
breadcrumbs and page title.

To test, apply the patch and go to Course reserves.

- If necessary, create a course.
- View the details of the course.
- Confirm that the list of details looks correct.
  - Test with all the optional fields empty: Section, term, instructor,
    staff note, public note. There should not be empty lines for these
    fields in the course details.
  - "Number of students" should show "0" if you left the field empty.
- Add multiple instructors to confirm that they are displayed in
  alignment with other course details.
- The page heading should match the page breadcrumb.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-01-10 20:25:46 UTC
Created attachment 176395 [details] [review]
Bug 38351: (follow-up) Tweaks to list and form alignment

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2025-01-10 20:42:27 UTC
Thanks Owen!
Comment 7 William Lavoie 2025-01-10 20:42:57 UTC
Created attachment 176396 [details] [review]
Bug 38351: (follow-up) Tweaks to list and form alignment

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: William Lavoie <william.lavoie@inLibro.com>
Comment 8 Owen Leonard 2025-02-12 14:16:53 UTC
Created attachment 177917 [details] [review]
Bug 38351: Improve layout of course reserve details

This patch makes some simple markup and CSS changes to the course
details page in order to improve the layout of the section:
- Add colons after labels.
- Replace fieldset.rows with div.rows (there's no form).
- Make list of instructors line up with other details.
- Do not display fields which are empty.

ALSO: Replaced the "Reserves" heading with course name, matching
breadcrumbs and page title.

To test, apply the patch and go to Course reserves.

- If necessary, create a course.
- View the details of the course.
- Confirm that the list of details looks correct.
  - Test with all the optional fields empty: Section, term, instructor,
    staff note, public note. There should not be empty lines for these
    fields in the course details.
  - "Number of students" should show "0" if you left the field empty.
- Add multiple instructors to confirm that they are displayed in
  alignment with other course details.
- The page heading should match the page breadcrumb.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 9 Owen Leonard 2025-02-12 14:16:55 UTC
Created attachment 177918 [details] [review]
Bug 38351: (follow-up) Tweaks to list and form alignment

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: William Lavoie <william.lavoie@inLibro.com>
Comment 10 Marcel de Rooy 2025-03-07 10:21:02 UTC
Created attachment 179053 [details] [review]
Bug 38351: Improve layout of course reserve details

This patch makes some simple markup and CSS changes to the course
details page in order to improve the layout of the section:
- Add colons after labels.
- Replace fieldset.rows with div.rows (there's no form).
- Make list of instructors line up with other details.
- Do not display fields which are empty.

ALSO: Replaced the "Reserves" heading with course name, matching
breadcrumbs and page title.

To test, apply the patch and go to Course reserves.

- If necessary, create a course.
- View the details of the course.
- Confirm that the list of details looks correct.
  - Test with all the optional fields empty: Section, term, instructor,
    staff note, public note. There should not be empty lines for these
    fields in the course details.
  - "Number of students" should show "0" if you left the field empty.
- Add multiple instructors to confirm that they are displayed in
  alignment with other course details.
- The page heading should match the page breadcrumb.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 11 Marcel de Rooy 2025-03-07 10:21:05 UTC
Created attachment 179054 [details] [review]
Bug 38351: (follow-up) Tweaks to list and form alignment

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: William Lavoie <william.lavoie@inLibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 12 Katrin Fischer 2025-03-07 16:47:28 UTC
The release notes seem to have some non-mark-down mark-up, can you please check and revise?
Comment 13 Katrin Fischer 2025-03-07 17:04:15 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 14 David Nind 2025-03-07 20:02:15 UTC
(In reply to Katrin Fischer from comment #12)
> The release notes seem to have some non-mark-down mark-up, can you please
> check and revise?

I didn't release we could use markdown "markup". Is there any specific guidance about this (markdown flavour, what works and what doesn't)?

I've simplified the list of improvements a bit, if this helps.