Created attachment 173983 [details] [review] Bug 38359: Update css class col-sm-offset-* no longer exists in bootstrap 5 and we should use offset-sm-* instead Test plan: 1) Enable ILLModule sys pref 2) Attempt to create a new ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Notice there is no left offset (as was before bug 35402 4) Apply patch. Repeat.
Created attachment 173984 [details] [review] Bug 38359: Update css class col-sm-offset-* no longer exists in bootstrap 5 and we should use offset-sm-* instead Test plan: 1) Enable ILLModule sys pref 2) Attempt to create a new ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Notice there is no left offset (as was before bug 35402 4) After creating the request, see the detail page: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 5) Verify same issue happens here. 6) Apply patch. Repeat test plan.
Please note that: $ git grep "col-sm-offset-2" # returns many other occurrences.
Created attachment 174053 [details] [review] Bug 38359: Update css class col-sm-offset-* no longer exists in bootstrap 5 and we should use offset-sm-* instead Test plan: 1) Enable ILLModule sys pref 2) Attempt to create a new ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Notice there is no left offset (as was before bug 35402 4) After creating the request, see the detail page: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 5) Verify same issue happens here. 6) Apply patch. Repeat test plan. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
That looks much better, thanks Pedro.
Created attachment 174100 [details] [review] Bug 38359: Update css class col-sm-offset-* no longer exists in bootstrap 5 and we should use offset-sm-* instead Test plan: 1) Enable ILLModule sys pref 2) Attempt to create a new ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Notice there is no left offset (as was before bug 35402 4) After creating the request, see the detail page: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 5) Verify same issue happens here. 6) Apply patch. Repeat test plan. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com>
Adding my sign-off, so that maybe Lucas's sign-off could count as QA.
(In reply to David Nind from comment #7) > Adding my sign-off, so that maybe Lucas's sign-off could count as QA. Yes, I am happy to count mine as Passed QA here.
Pushed for 24.11! Well done everyone, thank you!