Bug 38359 - ILL UI pages offset no longer works after Bootstrap 5 upgrade
Summary: ILL UI pages offset no longer works after Bootstrap 5 upgrade
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Pedro Amorim
QA Contact: Testopia
URL:
Keywords:
Depends on: 35402
Blocks:
  Show dependency treegraph
 
Reported: 2024-11-05 15:14 UTC by Pedro Amorim
Modified: 2024-12-05 21:57 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38359: Update css class (1.25 KB, patch)
2024-11-05 15:17 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38359: Update css class (1.43 KB, patch)
2024-11-05 15:18 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38359: Update css class (1.48 KB, patch)
2024-11-05 23:57 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38359: Update css class (1.53 KB, patch)
2024-11-06 22:29 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-11-05 15:14:40 UTC

    
Comment 1 Pedro Amorim 2024-11-05 15:17:01 UTC Comment hidden (obsolete)
Comment 2 Pedro Amorim 2024-11-05 15:18:09 UTC
Created attachment 173984 [details] [review]
Bug 38359: Update css class

col-sm-offset-* no longer exists in bootstrap 5 and we should use offset-sm-* instead

Test plan:
1) Enable ILLModule sys pref
2) Attempt to create a new ILL request:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Notice there is no left offset (as was before bug 35402
4) After creating the request, see the detail page:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1
5) Verify same issue happens here.
6) Apply patch. Repeat test plan.
Comment 3 Pedro Amorim 2024-11-05 15:39:01 UTC
Please note that:
$ git grep "col-sm-offset-2" # returns many other occurrences.
Comment 4 Lucas Gass (lukeg) 2024-11-05 23:57:51 UTC
Created attachment 174053 [details] [review]
Bug 38359: Update css class

col-sm-offset-* no longer exists in bootstrap 5 and we should use offset-sm-* instead

Test plan:
1) Enable ILLModule sys pref
2) Attempt to create a new ILL request:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Notice there is no left offset (as was before bug 35402
4) After creating the request, see the detail page:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1
5) Verify same issue happens here.
6) Apply patch. Repeat test plan.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Lucas Gass (lukeg) 2024-11-05 23:57:59 UTC
That looks much better, thanks Pedro.
Comment 6 David Nind 2024-11-06 22:29:04 UTC
Created attachment 174100 [details] [review]
Bug 38359: Update css class

col-sm-offset-* no longer exists in bootstrap 5 and we should use offset-sm-* instead

Test plan:
1) Enable ILLModule sys pref
2) Attempt to create a new ILL request:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Notice there is no left offset (as was before bug 35402
4) After creating the request, see the detail page:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1
5) Verify same issue happens here.
6) Apply patch. Repeat test plan.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2024-11-06 22:30:04 UTC
Adding my sign-off, so that maybe Lucas's sign-off could count as QA.
Comment 8 Lucas Gass (lukeg) 2024-11-07 15:27:34 UTC
(In reply to David Nind from comment #7)
> Adding my sign-off, so that maybe Lucas's sign-off could count as QA.

Yes, I am happy to count mine as Passed QA here.
Comment 9 Katrin Fischer 2024-11-07 16:34:03 UTC
Pushed for 24.11!

Well done everyone, thank you!