In renewal part there is a missunderstanding. Let me explain with an example. The sentence in English: "2 of 3 renewals remaining" is translated as "2 uzatma hakkınızdan 3 tane kaldı" in Turkish. This is wrong. Right Turkish translation must be like this : "3 uzatma hakkınızdan 2 tane kaldı" This information can be seen in (with a user having renewals): cgi-bin/koha/opac-user.pl page of user. cgi-bin/koha/circ/circulation.pl?borrowernumber=xxxx
Created attachment 174075 [details] [review] Bug 38377: Improve translatability of "%s/%s renewals remaining" See comment 0 The sentence in English: "2 of 3 renewals remaining" is translated as "2 uzatma hakkınızdan 3 tane kaldı" in Turkish. This is wrong. Right Turkish translation must be like this : "3 uzatma hakkınızdan 2 tane kaldı" We cannot use %s/%s as the order will be preserved, we need to use named placeholders. Test plan: Apply this patch % gulp po:update --lang LANG Go to misc/translator/po % git grep 'renewals remaining' Translate the occurrences, remove fuzzy sudo koha-translate --update LANG --dev kohadev restart_all Enable LANG for both staff and OPAC Have a look at the checkouts table and notice that the strings have been correctly translated