Bug 38389 - Add 'subscriptions' embed to vendors endpoint
Summary: Add 'subscriptions' embed to vendors endpoint
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
Depends on: 38011
Blocks:
  Show dependency tree / graph
 
Reported: 2024-11-07 11:59 UTC by Martin Renvoize (ashimema)
Modified: 2024-11-07 12:55 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 38389: Add subscriptions to vendor endpoint as embed (3.60 KB, patch)
2024-11-07 12:51 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2024-11-07 11:59:54 UTC 
We should be able to embed subscriptions in the vendors endpoint
Comment 1 Martin Renvoize (ashimema) 2024-11-07 12:51:46 UTC 
Created attachment 174191 [details] [review]
Bug 38389: Add subscriptions to vendor endpoint as embed
Comment 2 Martin Renvoize (ashimema) 2024-11-07 12:53:09 UTC 
This is a work in progress.. we could do with a discussion around the mapping of the various fields involved in the subscription table and object.

I've made a start and thankfully we're not actually embedding anywhere yet, but there are a number of places where in theory we do already allow this embed and we've not linked it to a spec or added the required to_api_mapping method!