This tests look fragile. 'Got correct expired screen message' fails if `dateformat` is not `us`. To test: 1. Change the `dateformat` syspref to any value other than `us`(shows as mm/dd/yyyy) 2. Run: $ ktd --shell k$ prove t/db_dependent/SIP/Transaction.t => FAIL: Tests fail because of the resulting string containing an unexpected date format. 3. Repeat 1-2 with other formats => FAIL: SAme 4. Choose `us` 5. Repeat 2 => SUCCESS: It passes
Created attachment 174384 [details] [review] Bug 38418: Make SIP/Transaction.t run on all dateformat values To test: 1. Change the `dateformat` syspref to any value other than `us`(shows as mm/dd/yyyy) 2. Run: $ ktd --shell k$ prove t/db_dependent/SIP/Transaction.t => FAIL: Tests fail because of the resulting string containing an unexpected date format. 3. Repeat 1-2 with other formats => FAIL: SAme 4. Choose `us` 5. Repeat 2 => SUCCESS: It passes 6. Apply this patch 7. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 174386 [details] [review] Bug 38418: Make SIP/Transaction.t run on all dateformat values To test: 1. Change the `dateformat` syspref to any value other than `us`(shows as mm/dd/yyyy) 2. Run: $ ktd --shell k$ prove t/db_dependent/SIP/Transaction.t => FAIL: Tests fail because of the resulting string containing an unexpected date format. 3. Repeat 1-2 with other formats => FAIL: SAme 4. Choose `us` 5. Repeat 2 => SUCCESS: It passes 6. Apply this patch 7. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Caused by which change?
Created attachment 174449 [details] [review] Bug 38418: Make SIP/Transaction.t run on all dateformat values To test: 1. Change the `dateformat` syspref to any value other than `us`(shows as mm/dd/yyyy) 2. Run: $ ktd --shell k$ prove t/db_dependent/SIP/Transaction.t => FAIL: Tests fail because of the resulting string containing an unexpected date format. 3. Repeat 1-2 with other formats => FAIL: SAme 4. Choose `us` 5. Repeat 2 => SUCCESS: It passes 6. Apply this patch 7. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(In reply to Jonathan Druart from comment #3) > Caused by which change? selenium/patrons_search.t was failing on Jenkins and so didn't rollback the dateformat syspref to its default value.
Pushed for 24.11! Well done everyone, thank you!
Merge conflicts in 24.05.x, no backport.