While not critical, our used version is dated and we keep getting warnings about it when `reset_all` is run or at `KTD` startup time. https://github.com/Redocly/redocly-cli/releases
Created attachment 174414 [details] [review] Bug 38424: Upgrade redoclyly/cli version to latest stable This patch updates the used version of redocly/cli to the latest stable. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ yarn api:bundle => FAIL: You get ``` yarn run v1.22.22 $ redocly bundle --ext json api/v1/swagger/swagger.yaml --output api/v1/swagger/swagger_bundle.json ╔════════════════════════════════════════════════════════╗ ║ ║ ║ A new version of Redocly CLI (1.25.11) is available. ║ ║ Update now: `npm i -g @redocly/cli@latest`. ║ ║ Changelog: https://redocly.com/docs/cli/changelog/ ║ ║ ║ ╚════════════════════════════════════════════════════════╝ bundling api/v1/swagger/swagger.yaml... 📦 Created a bundle for api/v1/swagger/swagger.yaml at api/v1/swagger/swagger_bundle.json 207ms. Done in 1.34s. ``` 3. Apply this patch 4. Run: k$ sudo yarn install --modules-folder /kohadevbox/node_modules 5. Repeat 2: => SUCCESS: You get ``` yarn run v1.22.22 $ redocly bundle --ext json api/v1/swagger/swagger.yaml --output api/v1/swagger/swagger_bundle.json bundling api/v1/swagger/swagger.yaml... 📦 Created a bundle for api/v1/swagger/swagger.yaml at api/v1/swagger/swagger_bundle.json 200ms. Done in 1.29s. ``` 6. Restart plack and check the API loads without issues: k$ koha-plack --restart kohadev; tail -f /var/log/koha/kohadev/*.log 7. Run the tests: k$ prove -r t/db_dependent/api/ => SUCCESS: No failures 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
yarn.lock should be generated by RM.
Created attachment 174789 [details] [review] Bug 38424: Upgrade redoclyly/cli version to latest stable This patch updates the used version of redocly/cli to the latest stable. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ yarn api:bundle => FAIL: You get ``` yarn run v1.22.22 $ redocly bundle --ext json api/v1/swagger/swagger.yaml --output api/v1/swagger/swagger_bundle.json ╔════════════════════════════════════════════════════════╗ ║ ║ ║ A new version of Redocly CLI (1.25.11) is available. ║ ║ Update now: `npm i -g @redocly/cli@latest`. ║ ║ Changelog: https://redocly.com/docs/cli/changelog/ ║ ║ ║ ╚════════════════════════════════════════════════════════╝ bundling api/v1/swagger/swagger.yaml... 📦 Created a bundle for api/v1/swagger/swagger.yaml at api/v1/swagger/swagger_bundle.json 207ms. Done in 1.34s. ``` 3. Apply this patch 4. Run: k$ sudo yarn install --modules-folder /kohadevbox/node_modules 5. Repeat 2: => SUCCESS: You get ``` yarn run v1.22.22 $ redocly bundle --ext json api/v1/swagger/swagger.yaml --output api/v1/swagger/swagger_bundle.json bundling api/v1/swagger/swagger.yaml... 📦 Created a bundle for api/v1/swagger/swagger.yaml at api/v1/swagger/swagger_bundle.json 200ms. Done in 1.29s. ``` 6. Restart plack and check the API loads without issues: k$ koha-plack --restart kohadev; tail -f /var/log/koha/kohadev/*.log 7. Run the tests: k$ prove -r t/db_dependent/api/ => SUCCESS: No failures 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
RM: generate yarn.lock and ask for ktd rebuild when this is pushed.
(In reply to Jonathan Druart from comment #4) > RM: generate yarn.lock and ask for ktd rebuild when this is pushed. OK, I need a little help here as I didn't find it in documentation: https://wiki.koha-community.org/wiki/Release_management#Yarn How do I rebuild the yarn.lock? * Tried yarn build with no result. * Tried yarn install, which created a yarn.lock file. Is this the correct way? Please catch me on Mattermost so we can schedule push/ktd rebuild.
Pushed for 24.11! Well done everyone, thank you!