Bug 38434 - (Bug 35906 follow-up) dbrev different from kohastructure.sql
Summary: (Bug 35906 follow-up) dbrev different from kohastructure.sql
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Database (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Thibaud Guillot (thibaud_g)
QA Contact: Testopia
URL:
Keywords:
Depends on: 35906
Blocks:
  Show dependency treegraph
 
Reported: 2024-11-13 16:17 UTC by Fridolin Somers
Modified: 2024-12-05 22:29 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38434: Fix to define the same structure as kohastructure.sql (965 bytes, patch)
2024-11-14 10:17 UTC, Thibaud Guillot (thibaud_g)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2024-11-13 16:17:37 UTC
Bug 35906 added itemtypes.bookable :

installer/data/mysql/kohastructure.sql :
`bookable` tinyint(1) NOT NULL DEFAULT 0

installer/data/mysql/db_revs/240600045.pl :
ALTER TABLE itemtypes ADD COLUMN bookable INT(1) DEFAULT 0 AFTER automatic_checkin

Koha/Schema/Result/Itemtype.pm :
  "bookable",
  { data_type => "tinyint", default_value => 0, is_nullable => 0 },

So dbrev needs to be fixed
Comment 1 Thibaud Guillot (thibaud_g) 2024-11-14 10:17:08 UTC
Created attachment 174493 [details] [review]
Bug 38434: Fix to define the same structure as kohastructure.sql
Comment 2 Katrin Fischer 2024-11-14 10:40:29 UTC
Picking this one a follow-up of 35906 directly for main.
Comment 3 Katrin Fischer 2024-11-14 14:33:02 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 4 Lucas Gass (lukeg) 2024-12-05 22:29:38 UTC
Missing 24.05.x deps, no backport.