This looks wrong: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt: $(".dt_button_clear_filter").addClass("disabled"); koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt: $(".dt_button_clear_filter").removeClass("disabled"); koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt: $(".dt_button_clear_filter").addClass("disabled"); koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt: $(".dt_button_clear_filter").removeClass("disabled"); koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt: $(".dt_button_clear_filter").on("click", function(){
Created attachment 177263 [details] [review] Bug 38440: Remove useless handling of .dt_button_clear_filter There is only one occurrence in the whole codebase, we should not handle the behaviour of this "clear filter" button outside of datatables.js Test plan: Go to Additional content Use the form on the left side of the page, confirm that the table is filtered when a new keyword is entered Notice that the global search of the table is filled in with the keyword "Clear filters" should reset both inputs, and redraw the table
Created attachment 177273 [details] [review] Bug 38440: Remove useless handling of .dt_button_clear_filter There is only one occurrence in the whole codebase, we should not handle the behaviour of this "clear filter" button outside of datatables.js Test plan: Go to Additional content Use the form on the left side of the page, confirm that the table is filtered when a new keyword is entered Notice that the global search of the table is filled in with the keyword "Clear filters" should reset both inputs, and redraw the table Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 177400 [details] [review] Bug 38440: Remove useless handling of .dt_button_clear_filter There is only one occurrence in the whole codebase, we should not handle the behaviour of this "clear filter" button outside of datatables.js Test plan: Go to Additional content Use the form on the left side of the page, confirm that the table is filtered when a new keyword is entered Notice that the global search of the table is filled in with the keyword "Clear filters" should reset both inputs, and redraw the table Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
PQA but also setting to BLOCKED as we wait for dependencies.