The string "Waiting at %s, %s since %s." in koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc is missing in Weblate. Is there a problem with the string extraction?
We found out today that the strings hadn't been synced properly for a little while. Please check again tomorrow!
Indeed, please check again tomorrow.
This is valid.
Created attachment 174672 [details] [review] Bug 38450: Fix some translation pickups _("This %s is picked").format(foo) _("This %s is NOT picked".format(bar)) Both constructs are valid, but our translation script does not pick the second one. I found very few occurrences (using `git grep '.".format('`) that are displayed on the UI. I don't have the time right now to deep dive into the translation script to fix this problem, easier to adjust the occurrences. How to prevent that in the future however? We could raise a warning from the QA script. Test plan: Do not apply this patch Generate the strings (`gulp po:update --lang LANG`) cd misc/translator/po && git commit -a -m"wip" Apply this patch, regenerate the strings cd misc/translator/po && git diff Notice the changes, you should see new translations added to the .po files. Ideally translate them, install the templates and confirm that the new strings are translated on the UI.
(In reply to Jonathan Druart from comment #4) > How to prevent that in the future however? We could raise a warning from > the QA script. Opened https://gitlab.com/koha-community/qa-test-tools/-/issues/89
Created attachment 175013 [details] [review] Bug 38450: Fix some translation pickups _("This %s is picked").format(foo) _("This %s is NOT picked".format(bar)) Both constructs are valid, but our translation script does not pick the second one. I found very few occurrences (using `git grep '.".format('`) that are displayed on the UI. I don't have the time right now to deep dive into the translation script to fix this problem, easier to adjust the occurrences. How to prevent that in the future however? We could raise a warning from the QA script. Test plan: Do not apply this patch Generate the strings (`gulp po:update --lang LANG`) cd misc/translator/po && git commit -a -m"wip" Apply this patch, regenerate the strings cd misc/translator/po && git diff Notice the changes, you should see new translations added to the .po files. Ideally translate them, install the templates and confirm that the new strings are translated on the UI. Signed-off-by: David Nind <david@davidnind.com>