Bug 38452 - Inventory tool barcodes should not be case sensitive
Summary: Inventory tool barcodes should not be case sensitive
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-14 22:37 UTC by Lucas Gass (lukeg)
Modified: 2024-11-29 17:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38452: Add lc() for case insensitivity (1.24 KB, patch)
2024-11-15 23:05 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38452: Add lc() for case insensitivity (1.29 KB, patch)
2024-11-29 16:59 UTC, ByWater Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-11-14 22:37:06 UTC
I say this because it doesn't appear like we honor case sensitivity for barcodes elsewhere. 

So, to recreate:
1. Create an item give it a barcode like 'abc123';
2. Try creating a 2nd item with a barcode: 'ABC123', you get an error 'Error saving item: Barcode must be unique.'
3. Checkin the item 'ABC123', the 'abc123' item successfully checks in. 
4. The case doesn't seem to matter elsewhere in Koha ( check-in, checkout, searching, batch tools )
5. Try the inventory tool and use 'ABC123'. The barcode is not found. 

If Koha treats 'ABC123' and 'abc123' the same when creating an item, it should probably treat them the same when using the inventory tool.
Comment 1 Lucas Gass (lukeg) 2024-11-15 23:05:32 UTC
Created attachment 174638 [details] [review]
Bug 38452: Add lc() for case insensitivity

To test:
1. Create an item give it a barcode like 'abc123';
2. Try creating a 2nd item with a barcode: 'ABC123', you get an error 'Error saving item: Barcode must be unique.'
3. Checkin the item 'ABC123', the 'abc123' item successfully checks in.
4. The case doesn't seem to matter elsewhere in Koha ( check-in, checkout, searching, batch tools )
5. Try the inventory tool and use 'ABC123'. The barcode is not found.
6. APPLY PATCH, restart_all
7. Try the inventory tool again with both 'abc123' and 'ABC123', they should now both work.
Comment 2 ByWater Sandboxes 2024-11-29 16:59:03 UTC
Created attachment 175031 [details] [review]
Bug 38452: Add lc() for case insensitivity

To test:
1. Create an item give it a barcode like 'abc123';
2. Try creating a 2nd item with a barcode: 'ABC123', you get an error 'Error saving item: Barcode must be unique.'
3. Checkin the item 'ABC123', the 'abc123' item successfully checks in.
4. The case doesn't seem to matter elsewhere in Koha ( check-in, checkout, searching, batch tools )
5. Try the inventory tool and use 'ABC123'. The barcode is not found.
6. APPLY PATCH, restart_all
7. Try the inventory tool again with both 'abc123' and 'ABC123', they should now both work.

Signed-off-by: Kevin ONeil <kco.ipad@ipad.com>
Comment 3 Kevin ONeil 2024-11-29 17:00:49 UTC
Laura O’Neil assisted with this sign off.