Currently the cities dropdown does not work in the patron quick add, in fact city doesn't seem to work due to the way the selector/id are formed To recreate: 1 - Administratoin->Cities and towns 2 - Define several cities 3 - http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronQuickAddFields 4 - Select city,state, zipcode and some other fields 5 - Patrons->Quick add new patron 6 - Note city field/dropdown does not show
Created attachment 174586 [details] [review] Bug 38459: Ensure cities field works in patron quick add This patch adjust the selector for quick add and updates the change event for the city dropdown to affect quickadd fields as well To test: 1 - Administration->Cities and towns 2 - Define several cities 3 - http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronQuickAddFields 4 - Select city,state, zipcode and some other fields 5 - Patrons->Quick add new patron 6 - Note city field/dropdown does not show 7 - Apply patch 8 - Reload 9 - City dropdown shows! 10 - State and zip are updated when city is selected! 11 - Celebrate!
Created attachment 175946 [details] [review] Bug 38459: Ensure cities field works in patron quick add This patch adjust the selector for quick add and updates the change event for the city dropdown to affect quickadd fields as well To test: 1 - Administration->Cities and towns 2 - Define several cities 3 - http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronQuickAddFields 4 - Select city,state, zipcode and some other fields 5 - Patrons->Quick add new patron 6 - Note city field/dropdown does not show 7 - Apply patch 8 - Reload 9 - City dropdown shows! 10 - State and zip are updated when city is selected! 11 - Celebrate! Signed-off-by: David Nind <david@davidnind.com>
Created attachment 175983 [details] [review] Bug 38459: Ensure cities field works in patron quick add This patch adjust the selector for quick add and updates the change event for the city dropdown to affect quickadd fields as well To test: 1 - Administration->Cities and towns 2 - Define several cities 3 - http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronQuickAddFields 4 - Select city,state, zipcode and some other fields 5 - Patrons->Quick add new patron 6 - Note city field/dropdown does not show 7 - Apply patch 8 - Reload 9 - City dropdown shows! 10 - State and zip are updated when city is selected! 11 - Celebrate! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.03