Bug 38459 - Cities dropdown should work for quick add form as well
Summary: Cities dropdown should work for quick add form as well
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Matt Blenkinsop
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-15 14:53 UTC by Nick Clemens (kidclamp)
Modified: 2025-03-19 23:01 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the quick add patron form so that the city field uses a dropdown list and populates other fields (state, ZIP/Postal code, and country), where cities are defined in Administration > Patrons and circulation > Cities and towns.
Version(s) released in:
25.05.00,24.11.03
Circulation function:


Attachments
Bug 38459: Ensure cities field works in patron quick add (3.07 KB, patch)
2024-11-15 14:55 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 38459: Ensure cities field works in patron quick add (3.12 KB, patch)
2024-12-26 18:10 UTC, David Nind
Details | Diff | Splinter Review
Bug 38459: Ensure cities field works in patron quick add (3.20 KB, patch)
2024-12-30 10:11 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2024-11-15 14:53:30 UTC
Currently the cities dropdown does not work in the patron quick add, in fact city doesn't seem to work due to the way the selector/id are formed

To recreate:
1 - Administratoin->Cities and towns
2 - Define several cities
3 - http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronQuickAddFields
4 - Select city,state, zipcode and some other fields
5 - Patrons->Quick add new patron
6 - Note city field/dropdown does not show
Comment 1 Nick Clemens (kidclamp) 2024-11-15 14:55:41 UTC
Created attachment 174586 [details] [review]
Bug 38459: Ensure cities field works in patron quick add

This patch adjust the selector for quick add and updates the change event for the city
dropdown to affect quickadd fields as well

To test:
 1 - Administration->Cities and towns
 2 - Define several cities
 3 - http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronQuickAddFields
 4 - Select city,state, zipcode and some other fields
 5 - Patrons->Quick add new patron
 6 - Note city field/dropdown does not show
 7 - Apply patch
 8 - Reload
 9 - City dropdown shows!
10 - State and zip are updated when city is selected!
11 - Celebrate!
Comment 2 David Nind 2024-12-26 18:10:51 UTC
Created attachment 175946 [details] [review]
Bug 38459: Ensure cities field works in patron quick add

This patch adjust the selector for quick add and updates the change event for the city
dropdown to affect quickadd fields as well

To test:
 1 - Administration->Cities and towns
 2 - Define several cities
 3 - http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronQuickAddFields
 4 - Select city,state, zipcode and some other fields
 5 - Patrons->Quick add new patron
 6 - Note city field/dropdown does not show
 7 - Apply patch
 8 - Reload
 9 - City dropdown shows!
10 - State and zip are updated when city is selected!
11 - Celebrate!

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Matt Blenkinsop 2024-12-30 10:11:33 UTC
Created attachment 175983 [details] [review]
Bug 38459: Ensure cities field works in patron quick add

This patch adjust the selector for quick add and updates the change event for the city
dropdown to affect quickadd fields as well

To test:
 1 - Administration->Cities and towns
 2 - Define several cities
 3 - http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronQuickAddFields
 4 - Select city,state, zipcode and some other fields
 5 - Patrons->Quick add new patron
 6 - Note city field/dropdown does not show
 7 - Apply patch
 8 - Reload
 9 - City dropdown shows!
10 - State and zip are updated when city is selected!
11 - Celebrate!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 4 Katrin Fischer 2024-12-30 11:10:15 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Paul Derscheid 2025-03-19 23:01:11 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.03