17:00:43 koha_1 | # Failed test 'Time status changed equals time queued when created in message_queue table' 17:00:43 koha_1 | # at t/db_dependent/Letters.t line 156. 17:00:43 koha_1 | # got: '2024-11-15 16:00:00' 17:00:43 koha_1 | # expected: '2024-11-15 15:59:59' 17:00:43 koha_1 | # Looks like you failed 1 test of 103. 17:00:43 koha_1 | [16:00:09] t/db_dependent/Letters.t .................................................... It looks like it took a little longer than expected maybe and the test fails because of it. If this is the issue, we could make it a little more robust.
It should use t::lib::Dates::compare
Again Koha_Main_U24/214 18:30:25 koha_1 | # Failed test 'Time status changed equals time queued when created in message_queue table' 18:30:25 koha_1 | # at t/db_dependent/Letters.t line 156. 18:30:25 koha_1 | # got: '2025-02-05 17:27:07' 18:30:25 koha_1 | # expected: '2025-02-05 17:27:06' 18:30:25 koha_1 | # Looks like you failed 1 test of 104. 18:30:25 koha_1 | [17:27:13] t/db_dependent/Letters.t
Created attachment 177676 [details] [review] Bug 38474: Prevent Letters.t to fail on slow server We must always use t::lib::Dates::compare when we compare dates in tests.
Pushed for 25.05! Well done everyone, thank you!