Bug 38483 - C4::Heading::preferred_authorities is not used
Summary: C4::Heading::preferred_authorities is not used
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Janusz Kaczmarek
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-19 12:20 UTC by Janusz Kaczmarek
Modified: 2025-04-18 18:55 UTC (History)
6 users (show)

See Also:
GIT URL:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This removes an unused method 'preferred_authorities' (Return a list of authority records for headings that are a preferred form of the heading).
Version(s) released in:
25.05.00,24.11.03,24.05.08
Circulation function:


Attachments
Bug 38483: C4::Heading::preferred_authorities is not used (1.16 KB, patch)
2024-11-19 12:25 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 38483: C4::Heading::preferred_authorities is not used (1.22 KB, patch)
2024-11-21 05:31 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 38483: C4::Heading::preferred_authorities is not used (1.29 KB, patch)
2024-12-16 20:30 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2024-11-19 12:20:22 UTC
C4::Heading::preferred_authorities seems to be not used for ages (maybe never used?)

[and the call to _search inside preferred_authorities does not conform to the prototype -- missing $self in the parameter list]
Comment 1 Janusz Kaczmarek 2024-11-19 12:25:56 UTC
Created attachment 174787 [details] [review]
Bug 38483: C4::Heading::preferred_authorities is not used

C4::Heading::preferred_authorities seems to be not used for ages (maybe
never used?)

Test plan:
$ git grep preferred_authorities
-->   should return nothing

Sponsored-by: Ignatianum University in Cracow
Comment 2 Phil Ringnalda 2024-11-21 05:31:25 UTC
My production system uses an "authority control" vendor which when given a bib record with the bogus "650 0 ‡aNews‡xMagazine" returned four headings like "610 2 0 ‡aNational Early Warning System for Food Security (Malawi)‡xMagazine" from see-from headings for the acronym NEWS. Happy to see this removed before someone tries to actually use it.
Comment 3 Phil Ringnalda 2024-11-21 05:31:50 UTC
Created attachment 174867 [details] [review]
Bug 38483: C4::Heading::preferred_authorities is not used

C4::Heading::preferred_authorities seems to be not used for ages (maybe
never used?)

Test plan:
$ git grep preferred_authorities
-->   should return nothing

Sponsored-by: Ignatianum University in Cracow
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 4 Emily Lamancusa (emlam) 2024-12-16 20:30:54 UTC
Created attachment 175579 [details] [review]
Bug 38483: C4::Heading::preferred_authorities is not used

C4::Heading::preferred_authorities seems to be not used for ages (maybe
never used?)

Test plan:
$ git grep preferred_authorities
-->   should return nothing

Sponsored-by: Ignatianum University in Cracow
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 5 Emily Lamancusa (emlam) 2024-12-16 20:32:25 UTC
Looks good, thanks Janusz!
Comment 6 Katrin Fischer 2024-12-23 12:59:07 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 7 Paul Derscheid 2025-03-19 23:01:18 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.03
Comment 8 Alex Buckley 2025-03-20 21:04:00 UTC
Nice work everyone!

Pushed to 24.05.x for 24.05.08
Comment 9 Fridolin Somers 2025-03-24 10:03:58 UTC
I prefer not impact 23.11.x for stability
Comment 10 Caroline Cyr La Rose 2025-04-18 18:55:31 UTC
Nothing to add/edit in the manual.