C4::Heading::preferred_authorities seems to be not used for ages (maybe never used?) [and the call to _search inside preferred_authorities does not conform to the prototype -- missing $self in the parameter list]
Created attachment 174787 [details] [review] Bug 38483: C4::Heading::preferred_authorities is not used C4::Heading::preferred_authorities seems to be not used for ages (maybe never used?) Test plan: $ git grep preferred_authorities --> should return nothing Sponsored-by: Ignatianum University in Cracow
My production system uses an "authority control" vendor which when given a bib record with the bogus "650 0 ‡aNews‡xMagazine" returned four headings like "610 2 0 ‡aNational Early Warning System for Food Security (Malawi)‡xMagazine" from see-from headings for the acronym NEWS. Happy to see this removed before someone tries to actually use it.
Created attachment 174867 [details] [review] Bug 38483: C4::Heading::preferred_authorities is not used C4::Heading::preferred_authorities seems to be not used for ages (maybe never used?) Test plan: $ git grep preferred_authorities --> should return nothing Sponsored-by: Ignatianum University in Cracow Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 175579 [details] [review] Bug 38483: C4::Heading::preferred_authorities is not used C4::Heading::preferred_authorities seems to be not used for ages (maybe never used?) Test plan: $ git grep preferred_authorities --> should return nothing Sponsored-by: Ignatianum University in Cracow Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Looks good, thanks Janusz!
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.03
Nice work everyone! Pushed to 24.05.x for 24.05.08
I prefer not impact 23.11.x for stability
Nothing to add/edit in the manual.