Bug 38491 - Update OAI servers code to current standards
Summary: Update OAI servers code to current standards
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 35659
Blocks:
  Show dependency tree / graph
 
Reported: 2024-11-20 10:35 UTC by Katrin Fischer
Modified: 2024-11-21 02:46 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2024-11-20 10:35:47 UTC 
admin/oai_servers.pl and .tt are really old style written, could have been nice to see them follow the current standard.

1. msg_added => should use a @messages array
2. add_form and op => Why 2 variables for the same purpose?
3. No try-catch!
4. type => $op eq 'add' ? lc $type : '' 
What is "type"? Is not used in template.