Created attachment 174832 [details] [review] Bug 38492: Update occurrences of _() to __() Test plan, ktd: 1) Generate translation files $ gulp po:update --lang de-DE 2) Verify that strings using _() do not exist on the pot file: $ cat -n misc/translator/Koha-messages-js.pot | grep "Copied!" $ cat -n misc/translator/Koha-messages-js.pot | grep "Form not submitted because of the following problem" $ cat -n misc/translator/Koha-messages-js.pot | grep "No matches found" 3) Apply patch. Repeat test plan.
Questions: 1) Is function _(s) in staff-global.js and onboarding.js necessary? 2) Should we add this rule to the qa script (need to use double underscore in .js files, not single underscore)?
Treating this one as a "follow-up" and picking it for master. Reviewed changes carefully.
(In reply to Pedro Amorim from comment #2) > Questions: > 1) Is function _(s) in staff-global.js and onboarding.js necessary? Yes you have to define it, otherwise the calls will fail. > 2) Should we add this rule to the qa script (need to use double underscore > in .js files, not single underscore)? yes, there is an issue already. https://gitlab.com/koha-community/qa-test-tools/-/issues/55
Pushed for 24.11! Well done everyone, thank you!