Bug 38502 - Use Bootstrap alert info class for messages on table settings page
Summary: Use Bootstrap alert info class for messages on table settings page
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-21 12:48 UTC by Owen Leonard
Modified: 2025-02-04 02:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the styles for informational messages on the table settings page (Administration > Additional parameters > Table settings). It updates the existing class (class="alert"), which doesn't add any style, to the Bootstrap 5 class (class="alert alert-info") - which now has a light blue background.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38502: Use Bootstrap alert info class for messages on table settings page (2.88 KB, patch)
2024-11-21 13:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38502: Use Bootstrap alert info class for messages on table settings page (2.92 KB, patch)
2025-01-03 00:36 UTC, David Nind
Details | Diff | Splinter Review
Bug 38502: Use Bootstrap alert info class for messages on table settings page (3.00 KB, patch)
2025-01-16 11:41 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-11-21 12:48:40 UTC
There are a couple of informational messages on the table settings page which are wrapped in <div class="alert">, a class which doesn't add any style. These should be updated to be <div class="alert alert-info">
Comment 1 Owen Leonard 2024-11-21 13:32:33 UTC
Created attachment 174871 [details] [review]
Bug 38502: Use Bootstrap alert info class for messages on table settings page

This patch updates the table settings template to add style to
informational messages.

To test, apply the patch and go to Administration -> Table settings.

- Go to Catalog -> detail -> holdings_table. Above the table's settings
  you should see a message, "Please not that if a field..." It should
  have the standard Bootstrap "info" style.
- Go to Cataloging -> additem. You should see a similarly styled
  message, "Changes made below..."

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2025-01-03 00:36:02 UTC
Created attachment 176108 [details] [review]
Bug 38502: Use Bootstrap alert info class for messages on table settings page

This patch updates the table settings template to add style to
informational messages.

To test, apply the patch and go to Administration -> Table settings.

- Go to Catalog -> detail -> holdings_table. Above the table's settings
  you should see a message, "Please not that if a field..." It should
  have the standard Bootstrap "info" style.
- Go to Cataloging -> additem. You should see a similarly styled
  message, "Changes made below..."

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Jonathan Druart 2025-01-16 11:41:37 UTC
Created attachment 176643 [details] [review]
Bug 38502: Use Bootstrap alert info class for messages on table settings page

This patch updates the table settings template to add style to
informational messages.

To test, apply the patch and go to Administration -> Table settings.

- Go to Catalog -> detail -> holdings_table. Above the table's settings
  you should see a message, "Please not that if a field..." It should
  have the standard Bootstrap "info" style.
- Go to Cataloging -> additem. You should see a similarly styled
  message, "Changes made below..."

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Katrin Fischer 2025-01-16 16:42:06 UTC
Pushed for 25.05!

Well done everyone, thank you!