Setting this minor as the conditions to reproduce this are seemingly quite niche.
Created attachment 174892 [details] [review] Bug 38505: CanBookBeIssued preparation: Add tests for falsy barcode prove t/db_dependent/Circulation.t
Created attachment 174893 [details] [review] Bug 38505: CanBookBeIssued preparation: Appropriate behavior when barcode is falsy Before applying this patch, apply the CanBookBeIssued preparation: tests patch and run that, Verify it fails, apply this patch. Run that same tests file again. ----- About this change ----- CanBookBeIssued wants to find one item given a barcode. If a falsy (undef, empty) barcode is supplied, UNKNOWN_BARCODE should be returned. Ensure this change does not introduce any regressions: prove t/db_dependent/Circulation* prove t/db_dependent/DecreaseLoanHighHolds.t prove t/db_dependent/rollingloans.t prove t/db_dependent/api/v1/checkouts.t prove t/db_dependent/Patron/Borrower_PrevCheckout.t
Created attachment 174894 [details] [review] Bug 38505: ill-requests.tt: Use .alert-warning when .alert exists Cosmetic changes only.
Created attachment 174895 [details] [review] Bug 38505: CirculateILL: Add UNKNOWN_BARCODE warning message Test plan, before applying patches: 1) Enable ILLModule system preferece. 2) Create a book ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) After creating a Book ILL request, go to its detail page and click on the newly created linked biblio 4) On the biblio detail, click 'NEW' -> 'New item', add type and home library + current library (dont enter a barcode) 5) Repeat 2) -> Click confirm request and continue. 6) Click "Check out" -> If theres a problem with the patron (expired or max checkouts hit) it'll say "A problem with patron occurred". Fix that adn click c"check out" again. 7) Notice the message "An unknown error occurred while trying to checkout the item" 8) Apply patches. Repeat. Notice the message you now get is 'The bibliographic record's item contains an unknown (or empty) barcode.'. This patch also adds a link to the respective biblio for Staff members' convenience.
Created attachment 174896 [details] [review] Bug 38505: CirculateILL: Add ILL::Request::check_out regression tests prove t/db_dependent/Koha/ILL/Requests.t
I tried to sign this one off just now but I think I have to wait until the sandbox is at 24.11 (not long now) and so incorporates the fix in bug 35570. Having that fix should see ILL bugs signed off much quicker… really looking forward to being able to use sandboxes that have the standard backend already installed.
(In reply to Ray Delahunty from comment #6) > I tried to sign this one off just now but I think I have to wait until the > sandbox is at 24.11 (not long now) and so incorporates the fix in bug 35570. > Having that fix should see ILL bugs signed off much quicker… really looking > forward to being able to use sandboxes that have the standard backend > already installed. When creating a sandbox, it will always use the latest "main" (next version to be). So bug 35570 is already available on sandboxes.
Created attachment 174924 [details] [review] Bug 38505: CirculateILL: Add ILL::Request::check_out regression tests prove t/db_dependent/Koha/ILL/Requests.t Signed-off-by: R <r.delahunty@arts.ac.uk>
Thanks Katrin- a silly mistake on my part. I had enabled CirculateILL but hadn’t saved the further change to enable the ILL feature, so I wasn’t seeing the feature. Fixed that and followed the test plan, repeating from step 2 after applying the patch and was able to do the sign-off.
(In reply to Ray Delahunty from comment #9) > Thanks Katrin- a silly mistake on my part. I had enabled CirculateILL but > hadn’t saved the further change to enable the ILL feature, so I wasn’t > seeing the feature. Fixed that and followed the test plan, repeating from > step 2 after applying the patch and was able to do the sign-off. Thanks!
Hi Ray, I've taken a second look at my test plan and it appears I forgot to specify that the CirculateILL sys pref needs to be enabled. Apologies. If you're tested and are okay to sign-off, I'll add your sign-off the other patches and update the bug. For some reason it seems the sandbox sign-off only did it for the last patch, not all 5 of them.
Yes, my second try at this worked perfectly, so it would be great to have this set to signed off. I didn't repeat from far enough back when following the test plan: 'Apply patches. Repeat' but once I thought about the unexpected result I realised I should have gone back to point 2 in the test plan and repeat from there.
Created attachment 174928 [details] [review] Bug 38505: CanBookBeIssued preparation: Add tests for falsy barcode prove t/db_dependent/Circulation.t Signed-off-by: R <r.delahunty@arts.ac.uk>
Created attachment 174929 [details] [review] Bug 38505: CanBookBeIssued preparation: Appropriate behavior when barcode is falsy Before applying this patch, apply the CanBookBeIssued preparation: tests patch and run that, Verify it fails, apply this patch. Run that same tests file again. ----- About this change ----- CanBookBeIssued wants to find one item given a barcode. If a falsy (undef, empty) barcode is supplied, UNKNOWN_BARCODE should be returned. Ensure this change does not introduce any regressions: prove t/db_dependent/Circulation* prove t/db_dependent/DecreaseLoanHighHolds.t prove t/db_dependent/rollingloans.t prove t/db_dependent/api/v1/checkouts.t prove t/db_dependent/Patron/Borrower_PrevCheckout.t Signed-off-by: R <r.delahunty@arts.ac.uk>
Created attachment 174930 [details] [review] Bug 38505: ill-requests.tt: Use .alert-warning when .alert exists Cosmetic changes only. Signed-off-by: R <r.delahunty@arts.ac.uk>
Created attachment 174931 [details] [review] Bug 38505: CirculateILL: Add UNKNOWN_BARCODE warning message Test plan, before applying patches: 1) Enable ILLModule system preferece. 2) Create a book ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) After creating a Book ILL request, go to its detail page and click on the newly created linked biblio 4) On the biblio detail, click 'NEW' -> 'New item', add type and home library + current library (dont enter a barcode) 5) Repeat 2) -> Click confirm request and continue. 6) Click "Check out" -> If theres a problem with the patron (expired or max checkouts hit) it'll say "A problem with patron occurred". Fix that adn click c"check out" again. 7) Notice the message "An unknown error occurred while trying to checkout the item" 8) Apply patches. Repeat. Notice the message you now get is 'The bibliographic record's item contains an unknown (or empty) barcode.'. This patch also adds a link to the respective biblio for Staff members' convenience. Signed-off-by: R <r.delahunty@arts.ac.uk>
Created attachment 174932 [details] [review] Bug 38505: CirculateILL: Add ILL::Request::check_out regression tests prove t/db_dependent/Koha/ILL/Requests.t Signed-off-by: R <r.delahunty@arts.ac.uk>