Bug 38509 - Displayed transfer destination is incorrect when a reservation has been found
Summary: Displayed transfer destination is incorrect when a reservation has been found
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-21 14:44 UTC by Baptiste Wojtkowski (bwoj)
Modified: 2025-04-08 16:50 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38509 - Displayed transfer destination is incorrect when a reservation has been found (2.86 KB, patch)
2024-11-21 14:54 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 38509: [22.11] Displayed transfer destination is incorrect when a reservation has been found (1.69 KB, patch)
2024-11-21 15:02 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 38509: Displayed transfer destination is incorrect when a reservation has been found (2.86 KB, patch)
2024-11-21 15:02 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Wojtkowski (bwoj) 2024-11-21 14:44:17 UTC
TEST PLAN FOR 24.05 (transfers appear to be broken on main atm, code is still invalid on main)

1 - Place a hold for Henry Acevedo on "39999000001334" (item level), ask for a pickup at centerville
2 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to centerville", which is not the behaviour or the button.

The correct text is "transfer to fairfield". The button must display the branch selected for the transfer and not the pickup location for the reservation (which is the branch at which we are located.)
Comment 1 Baptiste Wojtkowski (bwoj) 2024-11-21 14:54:47 UTC
Created attachment 174889 [details] [review]
Bug 38509 - Displayed transfer destination is incorrect when a reservation has been found

TEST PLAN FOR 24.05 (transfers appear to be broken on main atm, code is still invalid on main)

1 - Place a hold for Henry Acevedo on "39999000001334" (item level), ask for a pickup at centerville
2 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to centerville", which is not the behaviour of the button (the behaviour is correct, we want to perform the transfer and ignore the reservation). The last element of the pop-up is "transfer to: Centerville", which is incorrect too
APPLY PATCH
3 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to fairfield", which is not the behaviour or the button. The last element of the pop-up is "transfer to: Centerville".
Comment 2 Baptiste Wojtkowski (bwoj) 2024-11-21 15:02:00 UTC
Created attachment 174890 [details] [review]
Bug 38509: [22.11] Displayed transfer destination is incorrect when a reservation has been found

TEST PLAN FOR 22.11

1 - Place a hold for Henry Acevedo on "39999000001334" (item level), ask for a pickup at centerville
2 - At centerville, transfer the document to fairfield. There will be an array giving you three choices. The first one is "transfer to centerville", which is not the behaviour of the button (the behaviour is correct, we want to perform the transfer and ignore the reservation).
APPLY PATCH
3 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to fairfield", which is not the behaviour or the button.
Comment 3 Baptiste Wojtkowski (bwoj) 2024-11-21 15:02:47 UTC
Created attachment 174891 [details] [review]
Bug 38509: Displayed transfer destination is incorrect when a reservation has been found

TEST PLAN FOR 24.05 (transfers appear to be broken on main atm, code is still invalid on main)

1 - Place a hold for Henry Acevedo on "39999000001334" (item level), ask for a pickup at centerville
2 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to centerville", which is not the behaviour of the button (the behaviour is correct, we want to perform the transfer and ignore the reservation). The last element of the pop-up is "transfer to: Centerville", which is incorrect too
APPLY PATCH
3 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to fairfield", which is not the behaviour or the button. The last element of the pop-up is "transfer to: Centerville".
Comment 4 Baptiste Wojtkowski (bwoj) 2024-11-21 15:40:57 UTC
Removing status needs signoff: there is a bug with the behaviour of the first button ; no transfer is created however there is a feedback for transfer creation. I need to investigate.