TEST PLAN FOR 24.05 (transfers appear to be broken on main atm, code is still invalid on main) 1 - Place a hold for Henry Acevedo on "39999000001334" (item level), ask for a pickup at centerville 2 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to centerville", which is not the behaviour or the button. The correct text is "transfer to fairfield". The button must display the branch selected for the transfer and not the pickup location for the reservation (which is the branch at which we are located.)
Created attachment 174889 [details] [review] Bug 38509 - Displayed transfer destination is incorrect when a reservation has been found TEST PLAN FOR 24.05 (transfers appear to be broken on main atm, code is still invalid on main) 1 - Place a hold for Henry Acevedo on "39999000001334" (item level), ask for a pickup at centerville 2 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to centerville", which is not the behaviour of the button (the behaviour is correct, we want to perform the transfer and ignore the reservation). The last element of the pop-up is "transfer to: Centerville", which is incorrect too APPLY PATCH 3 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to fairfield", which is not the behaviour or the button. The last element of the pop-up is "transfer to: Centerville".
Created attachment 174890 [details] [review] Bug 38509: [22.11] Displayed transfer destination is incorrect when a reservation has been found TEST PLAN FOR 22.11 1 - Place a hold for Henry Acevedo on "39999000001334" (item level), ask for a pickup at centerville 2 - At centerville, transfer the document to fairfield. There will be an array giving you three choices. The first one is "transfer to centerville", which is not the behaviour of the button (the behaviour is correct, we want to perform the transfer and ignore the reservation). APPLY PATCH 3 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to fairfield", which is not the behaviour or the button.
Created attachment 174891 [details] [review] Bug 38509: Displayed transfer destination is incorrect when a reservation has been found TEST PLAN FOR 24.05 (transfers appear to be broken on main atm, code is still invalid on main) 1 - Place a hold for Henry Acevedo on "39999000001334" (item level), ask for a pickup at centerville 2 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to centerville", which is not the behaviour of the button (the behaviour is correct, we want to perform the transfer and ignore the reservation). The last element of the pop-up is "transfer to: Centerville", which is incorrect too APPLY PATCH 3 - At centerville, transfer the document to fairfield. There will be a pop-up giving you three choices. The first one is "transfer to fairfield", which is not the behaviour or the button. The last element of the pop-up is "transfer to: Centerville".
Removing status needs signoff: there is a bug with the behaviour of the first button ; no transfer is created however there is a feedback for transfer creation. I need to investigate.
Created attachment 185882 [details] [review] Bug 38509: Set correct transfer when a hold exists When you transfer a reserved item, a pop up appears. Depending on your action, if you choose to transfer the item anyway, the flow is not normal afterwards: - Item is not added to branchtransfers sql tables (so neither in "Transfer to receive" section) - It does not appear in the list under the transfer action - Its homebranch is immediately that of destination site Test plan: 1) Place hold on item specific or not, with pickup library different than current library for a real case 2) Transfer this item to another library (library choose for pickup for example) 3) You will see a pop up (with incorrect label destination) 4) After confirm it, pop up disappears and none transfer is saved in branchtransfers table (neither in 'transfer to receive' section) 5) On biblio page you will already see item with new homebranch 6) Apply this patch and restart_all 7) Perform the same action, place a hold then transfer item 8) Pop up shows now the correct label destination 9) Transfer will be correctly performed, appears in branchtransfers sql table and 'transfer to receive' section (for destination site). Also item homebranch does not changes until the destination site check in it. Sponsored-by: BibLibre Co-authored-by: bwoj - baptiste.wojtkowski@biblibre.com