https://schema.koha-community.org/24_05/tables/erm_agreements.html erm_agreements.license_info is limited to 80 characters. Users would like to be able to store more information here. erm_agreement_licenses.notes and erm_agreement_periods.notes are both MEDIUMTEXT fields allowing up to 16777215 characters.
Created attachment 174946 [details] [review] Bug 38522: Increase erm_agreements.license_info length to test: 1- try to save an agreement with 81+ characters in License Info 2- it does not save 3- apply patch, updatedatabase 4- repeat 1, it works!
Created attachment 174947 [details] [review] Bug 38522: update kohastructure.sql
Created attachment 174948 [details] [review] Bug 38522: update kohastructure.sql Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 174949 [details] [review] Bug 38522: Increase erm_agreements.license_info length to test: 1- try to save an agreement with 81+ characters in License Info 2- it does not save 3- apply patch, updatedatabase 4- repeat 1, it works! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 174950 [details] [review] Bug 38522: update kohastructure.sql Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Database update fails: ERROR: {UNKNOWN}: Undefined subroutine &C4::Installer::say_success called at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35145_order_patron_attributes.pl line 21. at /kohadevbox/koha/C4/Installer.pm line 743
(In reply to Lucas Gass (lukeg) from comment #6) > Database update fails: > > ERROR: {UNKNOWN}: Undefined subroutine &C4::Installer::say_success called > at > /kohadevbox/koha/installer/data/mysql/atomicupdate/ > bug_35145_order_patron_attributes.pl line 21. at > /kohadevbox/koha/C4/Installer.pm line 743 Sorry, commented on the wrong bug. This database update is great.
Hi Andrew, please make sure to use the new skeleton.pl as a base for your atomic update files. You should use "say_success" for example.
(In reply to Katrin Fischer from comment #8) > Hi Andrew, please make sure to use the new skeleton.pl as a base for your > atomic update files. You should use "say_success" for example. Hm, I just realized the file needs some more updating for the examples :)
Pushed for 25.05! Well done everyone, thank you!