Bug 38536 - Patrons requesting modifications: Expand correct panel
Summary: Patrons requesting modifications: Expand correct panel
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 35402
Blocks:
  Show dependency tree / graph
 
Reported: 2024-11-26 15:30 UTC by Owen Leonard
Modified: 2024-12-03 16:36 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the panels in the staff interface on the patrons requesting modifications page. The automatic panel expansion was not working as expected: - The first panel should expand by default (when there is no patron selected) - The panel should expand when a patron is selected (when opening from the patron's record) (This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11.)
Version(s) released in:
25.05.00
Circulation function:

Attachments
Bug 38536: Patrons requesting modifications: Expand correct panel (2.07 KB, patch)
2024-11-26 16:11 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 38536: Patrons requesting modifications: Expand correct panel (2.11 KB, patch)
2024-11-26 18:18 UTC, David Nind 		Details | Diff | Splinter Review
Bug 38536: Patrons requesting modifications: Expand correct panel (2.19 KB, patch)
2024-11-27 08:49 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-11-26 15:30:20 UTC 
We have code for expanding the requested accordion panel on the patrons requesting modifications page which needs to be updated for Bootstrap 5. If no borrowernumber has been passed to the template the first panel should expand by default. If a borrowernumber has been passed, that patron's section should automatically expand.
Comment 1 Owen Leonard 2024-11-26 16:11:55 UTC 
Created attachment 174989 [details] [review]
Bug 38536: Patrons requesting modifications: Expand correct panel

This patch updates the JavaScript on the patrons requesting modification
page in order to make it work following the upgrade to Bootstrap 5. The
automatic panel expansion is broken.

To test, apply the patch and enable, if necessary, the OPACPatronDetails
system preference.

- Log in to the OPAC and submit changes to your personal details.
- Do this again as a different user so that there is more than one
  pending request.
- From the staff interface home page, follow the link for "Patrons
  requesting modifications"
- Upon loading, the "Update patron records" page should automatically
  expand the first panel.
- Locate the patron record for the second of the patrons you requested
  updates for.
- From that patron's detail page, follow the "Review pending
  modifications" link.
- The panel containing that patron's information should expand by
  default.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2024-11-26 18:18:11 UTC 
Created attachment 174991 [details] [review]
Bug 38536: Patrons requesting modifications: Expand correct panel

This patch updates the JavaScript on the patrons requesting modification
page in order to make it work following the upgrade to Bootstrap 5. The
automatic panel expansion is broken.

To test, apply the patch and enable, if necessary, the OPACPatronDetails
system preference.

- Log in to the OPAC and submit changes to your personal details.
- Do this again as a different user so that there is more than one
  pending request.
- From the staff interface home page, follow the link for "Patrons
  requesting modifications"
- Upon loading, the "Update patron records" page should automatically
  expand the first panel.
- Locate the patron record for the second of the patrons you requested
  updates for.
- From that patron's detail page, follow the "Review pending
  modifications" link.
- The panel containing that patron's information should expand by
  default.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Jonathan Druart 2024-11-27 08:49:59 UTC 
Created attachment 175000 [details] [review]
Bug 38536: Patrons requesting modifications: Expand correct panel

This patch updates the JavaScript on the patrons requesting modification
page in order to make it work following the upgrade to Bootstrap 5. The
automatic panel expansion is broken.

To test, apply the patch and enable, if necessary, the OPACPatronDetails
system preference.

- Log in to the OPAC and submit changes to your personal details.
- Do this again as a different user so that there is more than one
  pending request.
- From the staff interface home page, follow the link for "Patrons
  requesting modifications"
- Upon loading, the "Update patron records" page should automatically
  expand the first panel.
- Locate the patron record for the second of the patrons you requested
  updates for.
- From that patron's detail page, follow the "Review pending
  modifications" link.
- The panel containing that patron's information should expand by
  default.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Katrin Fischer 2024-12-03 16:36:30 UTC 
Pushed for 25.05!

Well done everyone, thank you!