Bug 38537 - 'Edit items in a batch' should open in a new tab
Summary: 'Edit items in a batch' should open in a new tab
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Laura Escamilla
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-26 15:57 UTC by Laura Escamilla
Modified: 2024-12-17 15:41 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38537: Add target to open the form in a new tab (1.20 KB, patch)
2024-11-26 15:58 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 38537: Add target to open the form in a new tab (1.57 KB, patch)
2024-12-02 15:47 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Laura Escamilla 2024-11-26 15:57:38 UTC
Editing items in a batch should open in a new tab - it currently opens within the same tab.
Comment 1 Laura Escamilla 2024-11-26 15:58:52 UTC
Created attachment 174988 [details] [review]
Bug 38537: Add target to open the form in a new tab

To test:
1) Navigate to an item. 
2) In the top toolbar click on "Edit" and then the "Edit items in a batch" button. Notice that the new page opens within the same tab. 
3) Apply the patch. restart_all
4) Retry steps 1 & 2. This time notice that the new page opens within a new tab. 
5) Sign off and have a spectacular day.
Comment 2 Owen Leonard 2024-12-02 15:47:00 UTC
Created attachment 175054 [details] [review]
Bug 38537: Add target to open the form in a new tab

To test:
1) Navigate to an item.
2) In the top toolbar click on "Edit" and then the "Edit items in a
   batch" button. Notice that the new page opens within the same tab.
3) Apply the patch. restart_all
4) Retry steps 1 & 2. This time notice that the new page opens within a
   new tab.
5) Sign off and have a spectacular day.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Emily Lamancusa (emlam) 2024-12-17 15:35:14 UTC
Hi Laura, could you explain the use case for this? The change is straightforward enough, but everything else in the Edit menu opens within the same tab too, and changing just one link seems confusing to me.

Setting to FQA for feedback
Comment 4 Emily Lamancusa (emlam) 2024-12-17 15:41:43 UTC
Possibly out of scope, but I wonder if we could do something similar to bug 38476 to allow the user to open the link in a new tab themselves if they want to?