The configurations of the Transactions to date and Older transactions tables contain "orderFixed: [ 0, 'asc']" which sets a fixed order on the hidden first column. We should add "ordering: false" so that column sorting controls don't appear in the table headers.
Created attachment 175363 [details] [review] Bug 38667: Point of sale transaction history should not appear to be sortable This patch adds configuration options to the Point of sale "Transactions to date" and "Older transactions" tables so that they don't appear to be sortable. Both have an option that makes their sorting fixed. To test, apply the patch and go to Point of Sale. - Enable 'EnablePointOfSale' and 'UseCashRegisters' system preferences. - Add a least one cash register (Administration -> Cash registers). - Add a least one debit type (Administration -> Debit types). Check "Can be sold." - Go to the Point of Sale page. - Under "Items for purchase" click "Add" next to an item. - Under "Collect payment," fill out the form, including the cash register selection, and submit. - Click "Transaction history for..." in the sidebar menu. (You may have to click "Cash summary for..." and then the name of the register you used in your transaction. - Check that the "Transactions to date" and "Older transactions" tables do not have sorting indicators in the table headers. Sponsored-by: Athens County Public Libraries
Created attachment 175944 [details] [review] Bug 38667: Point of sale transaction history should not appear to be sortable This patch adds configuration options to the Point of sale "Transactions to date" and "Older transactions" tables so that they don't appear to be sortable. Both have an option that makes their sorting fixed. To test, apply the patch and go to Point of Sale. - Enable 'EnablePointOfSale' and 'UseCashRegisters' system preferences. - Add a least one cash register (Administration -> Cash registers). - Add a least one debit type (Administration -> Debit types). Check "Can be sold." - Go to the Point of Sale page. - Under "Items for purchase" click "Add" next to an item. - Under "Collect payment," fill out the form, including the cash register selection, and submit. - Click "Transaction history for..." in the sidebar menu. (You may have to click "Cash summary for..." and then the name of the register you used in your transaction. - Check that the "Transactions to date" and "Older transactions" tables do not have sorting indicators in the table headers. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
QA by RM
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.03
Not backporting to 24.05.x unless requested