Bug 38667 - Point of sale transaction history should not appear to be sortable
Summary: Point of sale transaction history should not appear to be sortable
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Point of Sale (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-10 16:25 UTC by Owen Leonard
Modified: 2025-04-17 06:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This removes the column sorting icons from the point of sale "Transactions to date" and "Older transactions" tables. The sort order for these tables is fixed, and clicking the icons had no effect.
Version(s) released in:
25.05.00,24.11.03
Circulation function:


Attachments
Bug 38667: Point of sale transaction history should not appear to be sortable (2.20 KB, patch)
2024-12-10 18:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38667: Point of sale transaction history should not appear to be sortable (2.24 KB, patch)
2024-12-26 17:56 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-12-10 16:25:34 UTC
The configurations of the Transactions to date and Older transactions tables contain "orderFixed: [ 0, 'asc']" which sets a fixed order on the hidden first column. 

We should add "ordering: false" so that column sorting controls don't appear in the table headers.
Comment 1 Owen Leonard 2024-12-10 18:14:44 UTC
Created attachment 175363 [details] [review]
Bug 38667: Point of sale transaction history should not appear to be sortable

This patch adds configuration options to the Point of sale "Transactions
to date" and "Older transactions" tables so that they don't appear to be
sortable. Both have an option that makes their sorting fixed.

To test, apply the patch and go to Point of Sale.

- Enable 'EnablePointOfSale' and 'UseCashRegisters' system preferences.
- Add a least one cash register (Administration -> Cash registers).
- Add a least one debit type (Administration -> Debit types). Check "Can
  be sold."
- Go to the Point of Sale page.
  - Under "Items for purchase" click "Add" next to an item.
  - Under "Collect payment," fill out the form, including the cash
    register selection, and submit.
- Click "Transaction history for..." in the sidebar menu. (You may have
  to click "Cash summary for..." and then the name of the register you
  used in your transaction.
  - Check that the "Transactions to date" and "Older transactions"
    tables do not have sorting indicators in the table headers.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2024-12-26 17:56:03 UTC
Created attachment 175944 [details] [review]
Bug 38667: Point of sale transaction history should not appear to be sortable

This patch adds configuration options to the Point of sale "Transactions
to date" and "Older transactions" tables so that they don't appear to be
sortable. Both have an option that makes their sorting fixed.

To test, apply the patch and go to Point of Sale.

- Enable 'EnablePointOfSale' and 'UseCashRegisters' system preferences.
- Add a least one cash register (Administration -> Cash registers).
- Add a least one debit type (Administration -> Debit types). Check "Can
  be sold."
- Go to the Point of Sale page.
  - Under "Items for purchase" click "Add" next to an item.
  - Under "Collect payment," fill out the form, including the cash
    register selection, and submit.
- Click "Transaction history for..." in the sidebar menu. (You may have
  to click "Cash summary for..." and then the name of the register you
  used in your transaction.
  - Check that the "Transactions to date" and "Older transactions"
    tables do not have sorting indicators in the table headers.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2024-12-27 15:27:03 UTC
QA by RM
Comment 4 Katrin Fischer 2024-12-27 16:36:42 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Paul Derscheid 2025-03-19 23:01:30 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.03
Comment 6 Wainui Witika-Park 2025-04-17 06:57:16 UTC
Not backporting to 24.05.x unless requested