Bug 38683 - OPAC cover images are only shown on first result page
Summary: OPAC cover images are only shown on first result page
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Owen Leonard
QA Contact: Matt Blenkinsop
URL:
Keywords:
Depends on: 26933
Blocks:
  Show dependency treegraph
 
Reported: 2024-12-12 08:10 UTC by Jan Kissig
Modified: 2025-02-03 19:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes OPAC search results when cover images are enabled - covers are now shown on all the result pages, instead of just the first page of results.
Version(s) released in:
25.05.00,24.11.02
Circulation function:


Attachments
Bug 38683: Opac cover images are only shown on fist result page (1.78 KB, patch)
2024-12-12 15:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38683: Opac cover images are only shown on fist result page (1.83 KB, patch)
2024-12-12 18:34 UTC, Jan Kissig
Details | Diff | Splinter Review
Bug 38683: Opac cover images are only shown on fist result page (1.90 KB, patch)
2024-12-12 18:51 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 38683: Opac cover images are only shown on fist result page (1.98 KB, patch)
2024-12-16 09:39 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Kissig 2024-12-12 08:10:22 UTC
When using cover images on the opac there is a strange behavior when there are more than 1 result pages. On the first result page everything works like expected, but on the subsequent result pages the cover images are not shown.

to reproduce:
- set system preference OPACAmazonCoverImages to show
- open opac an search for "and"
- the html structure for each result row is like:

<td class="selectcol"></td>
<td class="numcol"></td>
<td class="covercol"></td>
<td class="bibliocol"></td>

- then go to the second result page and check that the row structure differs now

<td class="selectcol"></td>
<td class="numcol"></td>
<td class="bibliocol"></td>
Comment 1 Owen Leonard 2024-12-12 15:19:13 UTC
Created attachment 175404 [details] [review]
Bug 38683: Opac cover images are only shown on fist result page

This patch corrects the OPAC search results template so that cover
images will be added on more than just the first page of results.

To test, apply the patch and enable a cover image system preference e.g.
OPACAmazonCoverImages. Perform a search in the OPAC which will return
multiple pages of results. Page through several pages of results to
confirm that cover images appear on each page.
Comment 2 Jan Kissig 2024-12-12 18:34:53 UTC Comment hidden (obsolete)
Comment 3 Biblibre Sandboxes 2024-12-12 18:51:47 UTC
Created attachment 175417 [details] [review]
Bug 38683: Opac cover images are only shown on fist result page

This patch corrects the OPAC search results template so that cover
images will be added on more than just the first page of results.

To test, apply the patch and enable a cover image system preference e.g.
OPACAmazonCoverImages. Perform a search in the OPAC which will return
multiple pages of results. Page through several pages of results to
confirm that cover images appear on each page.

Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 4 Matt Blenkinsop 2024-12-16 09:39:43 UTC
Created attachment 175487 [details] [review]
Bug 38683: Opac cover images are only shown on fist result page

This patch corrects the OPAC search results template so that cover
images will be added on more than just the first page of results.

To test, apply the patch and enable a cover image system preference e.g.
OPACAmazonCoverImages. Perform a search in the OPAC which will return
multiple pages of results. Page through several pages of results to
confirm that cover images appear on each page.

Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-12-23 08:38:32 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 6 Paul Derscheid 2025-02-03 19:09:39 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.01