Bug 38690 - NormalizeISBN assumes ISBN-10 format and discards ISBN-13 format
Summary: NormalizeISBN assumes ISBN-10 format and discards ISBN-13 format
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 38691
  Show dependency treegraph
 
Reported: 2024-12-12 15:51 UTC by Olli-Antti Kivilahti
Modified: 2024-12-12 16:15 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38690 - NormalizeISBN assumes ISBN-10 format and discards ISBN-13 format (878 bytes, patch)
2024-12-12 16:01 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2024-12-12 15:51:08 UTC
TEST PLAN:

1. Enable feature 'FRBRizeEditions' or 'OPACFRBRizeEditions'
2. Catalog three different editions of the same book with the same ISBN-13.
3. Look at the editions-tab in the biblio's detail-page. There is no editions-tab.

APPLY THIS PATCH:

3. Look at the editions-tab in the detail-page. There is a editions-tab, with only one record there.
Comment 1 Olli-Antti Kivilahti 2024-12-12 16:01:28 UTC
Created attachment 175410 [details] [review]
Bug 38690 - NormalizeISBN assumes ISBN-10 format and discards ISBN-13 format

While working to understand the 'FRBRizeEditions'-feature, I discovered that
the feature doesn't work with ISBN-13 format, and silently discards those.
Only ISBN-10 works due to this hard-coded constraint.
Comment 2 Olli-Antti Kivilahti 2024-12-12 16:02:23 UTC
The initial test plan does not work.