The invoice template ( Acquisitions -> Invoices -> Invoice details ) has some markup errors which should be fixed.
Created attachment 175457 [details] [review] Bug 38701: Fix HTML validity errors in invoice template This patch makes some markup corrections to acqui/invoice.tt so that it passes an HTML validity check. - Moves incorrectly placed </td> - Change <span> to <div> and remove invalid </br> - Correct instances of "<th class="replacementprice"/>" (th cannot be self-closed) - Add id attribute to inputs to correspond to existing labels - Change "all_fund_dropdown" markup so that it validates but still works with the active/inactive fund display. To test, apply the patch and go to Acquisitions -> Invoices. Perform an invoice search which will return results. In the results click the invoice number to view the invoice. - Test the "show inactive" checkbox corresponding to the "Shipping fund" dropdown. Checking and unchecking it should work correctly to show and hide inactive funds. - Run the page source through https://validator.w3.org and confirm that there are no errors coming from this template. Sponsored-by: Athens County Public Libraries
Created attachment 175469 [details] [review] Bug 38701: Fix HTML validity errors in invoice template This patch makes some markup corrections to acqui/invoice.tt so that it passes an HTML validity check. - Moves incorrectly placed </td> - Change <span> to <div> and remove invalid </br> - Correct instances of "<th class="replacementprice"/>" (th cannot be self-closed) - Add id attribute to inputs to correspond to existing labels - Change "all_fund_dropdown" markup so that it validates but still works with the active/inactive fund display. To test, apply the patch and go to Acquisitions -> Invoices. Perform an invoice search which will return results. In the results click the invoice number to view the invoice. - Test the "show inactive" checkbox corresponding to the "Shipping fund" dropdown. Checking and unchecking it should work correctly to show and hide inactive funds. - Run the page source through https://validator.w3.org and confirm that there are no errors coming from this template. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
TIL an inactive fund is any fund in an inactive budget, and, we have several severe validation errors that don't come from "this template." :)
(In reply to Phil Ringnalda from comment #3) > we have several > severe validation errors that don't come from "this template." Can you elaborate? I don't get any "severe" validations errors at all.
Ah, I didn't look at what the duplicate IDs did, only that they were from includes. Yeah, having duplicate IDs in unused and unshown code isn't severe. And it's been long enough since I last used a screen reader or had one installed that I don't actually know whether they now do a good job with <option value=""></option>, reading it as "No value selected" or something similar. Might be clear as a bell how to set a budget to the value "Not restricted to one library" or it might be impossible to tell when you have.
Sigh. Never mind me, I carefully validated aqbudgets.tt after I created an inactive budget, and didn't validate invoice.tt at all.
Created attachment 175805 [details] [review] Bug 38701: Fix HTML validity errors in invoice template This patch makes some markup corrections to acqui/invoice.tt so that it passes an HTML validity check. - Moves incorrectly placed </td> - Change <span> to <div> and remove invalid </br> - Correct instances of "<th class="replacementprice"/>" (th cannot be self-closed) - Add id attribute to inputs to correspond to existing labels - Change "all_fund_dropdown" markup so that it validates but still works with the active/inactive fund display. To test, apply the patch and go to Acquisitions -> Invoices. Perform an invoice search which will return results. In the results click the invoice number to view the invoice. - Test the "show inactive" checkbox corresponding to the "Shipping fund" dropdown. Checking and unchecking it should work correctly to show and hide inactive funds. - Run the page source through https://validator.w3.org and confirm that there are no errors coming from this template. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Awesome, thanks Owen!
Pushed for 25.05! Well done everyone, thank you!