Created attachment 175498 [details] [review] Bug 38715: Fix breadcrumbs for edit MARC record page Link that supposed to link to the record you're editing links on the edit page instead. This patch fixes it. To reproduce: 1. Go to any biblio and edit the record, click the book name in breadcrumbs on top of the edit page, it's gonna return you back to this same page. 2. Apply the patch. 3. Repeat step 1, it should properly return you to the biblo page.
Created attachment 175499 [details] [review] Bug 38715: Fix Breadcrumbs on Edit MARC Record Page The link in the breadcrumbs that is supposed to take you to the record you're editing instead redirects to the edit page itself. This patch fixes this problem. To reproduce: 1. Go to any biblio and edit the record, click the book name in breadcrumbs on top of the edit page, it's gonna return you back to this same page. 2. Apply the patch. 3. Repeat step 1, it should properly return you to the biblo page.
Hi Peter. The breadcrumbs are a navigation aid, and should reflect the path to the current page, and the actual page titles. I don't think the proposed change reflects this. I've added Owen into the bug, as he has done a lot of work over the last few releases fixing up the breadcrumbs, page titles, and browser page titles, to make them more consistent. Before the patch: - Browser title: Editing Record title (Record number XXX) > Cataloging > Koha - Breadcrumb: Cataloguing > Editing Record title (Record number XXX)* - Page title: Editing Record title (Record number XXX)+ * All italicised + Record title only italicised After the patch: - Browser title: Editing Record title (Record number XXX) > Cataloging > Koha - Breadcrumb: Cataloguing > Editing Record title (Record number XXX) > MARC record * - Page title: Editing Record title (Record number XXX)+ * All italicised, however 'Editing' not linked, and 'MARC record' linked but visually doesn't look like it is linked + Record title only italicised Also, for consistency, I think any changes made should be made to the authorities breadcrumbs and page titles as well. For authorities, these are currently: - Browser title: Modify authority #XXX (Term Type) > Authorities > Koha - Breadcrumb: Authorities > Modify authority #XXX (Term Type) - Page title: Modify authority #XXXX Term Type A further complication, is we mix up 'Modify' and 'Edit' - I think we've decided to use one, but I can't remember which one! This is a hard one! I'll attach some screenshots. David
Created attachment 175584 [details] Screenshots - Before and after patch Screenshots of editing a record page - before and after the patch.
Pages like this don't always have a clear context, making this tricky. The sequence "Home -> Cataloging -> [Title] comes from the classification of the edit process as a cataloging action. The fact that the "Cancel" option returns you to the bibliographic detail page fits into this framing: If you cancel the edit process you should go back to the view. It's true that the user may have arrived via a different path (catalog search -> bibliographic details -> edit) but these breadcrumbs orient the user to where they are, not where they came from. That's the way I see it anyway.