Bug 38744 - Tests in Koha/Biblio.t are not rolling back
Summary: Tests in Koha/Biblio.t are not rolling back
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-18 14:33 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-01-24 11:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38744: Wrap tests in Biblio.t inside a transaction (3.14 KB, patch)
2024-12-18 14:37 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 38744: Wrap tests in Biblio.t inside a transaction (3.12 KB, patch)
2025-01-21 19:10 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 38744: Wrap tests in Biblio.t inside a transaction (3.17 KB, patch)
2025-01-22 09:12 UTC, David Nind
Details | Diff | Splinter Review
Bug 38744: Wrap tests in Biblio.t inside a transaction (3.24 KB, patch)
2025-01-22 10:25 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38744: Add more missing txn (2.16 KB, patch)
2025-01-22 10:25 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2024-12-18 14:33:28 UTC

    
Comment 1 Tomás Cohen Arazi (tcohen) 2024-12-18 14:37:41 UTC
Created attachment 175653 [details] [review]
Bug 38744: Wrap tests in Biblio.t inside a transaction

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 David Nind 2024-12-24 19:56:15 UTC
I'm getting the sha1/fake ancestor error when I try to apply the patch:

git bz apply 38744

Bug 38744 - Tests in Koha/Biblio.t are not rolling back

175653 - Bug 38744: Wrap tests in Biblio.t inside a transaction

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 38744: Wrap tests in Biblio.t inside a transaction
error: sha1 information is lacking or useless (t/db_dependent/Koha/Biblio.t).
error: could not build fake ancestor
Patch failed at 0001 Bug 38744: Wrap tests in Biblio.t inside a transaction
...
Comment 3 Tomás Cohen Arazi (tcohen) 2025-01-21 19:10:18 UTC
Created attachment 176883 [details] [review]
Bug 38744: Wrap tests in Biblio.t inside a transaction

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 David Nind 2025-01-22 09:12:54 UTC
Created attachment 176887 [details] [review]
Bug 38744: Wrap tests in Biblio.t inside a transaction

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-01-22 09:13:39 UTC
Thanks Tomás! 

Tests pass before and after the patch: t/db_dependent/Koha/Biblio.t

David
Comment 6 Jonathan Druart 2025-01-22 10:25:28 UTC
Created attachment 176894 [details] [review]
Bug 38744: Wrap tests in Biblio.t inside a transaction

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2025-01-22 10:25:30 UTC
Created attachment 176895 [details] [review]
Bug 38744: Add more missing txn

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Tomás Cohen Arazi (tcohen) 2025-01-22 11:48:06 UTC
(In reply to Jonathan Druart from comment #7)
>
> Created attachment 176895 [details] [review] [review]
> Bug 38744: Add more missing txn

This feels like chasing a TGV.
Comment 9 Jonathan Druart 2025-01-22 11:59:05 UTC
(In reply to Tomás Cohen Arazi (tcohen) from comment #8)
> (In reply to Jonathan Druart from comment #7)
> >
> > Created attachment 176895 [details] [review] [review] [review]
> > Bug 38744: Add more missing txn
> 
> This feels like chasing a TGV.

They actually predate your patch :D
Comment 10 Katrin Fischer 2025-01-24 10:46:43 UTC
Thanks for tracking these down!
Comment 11 Katrin Fischer 2025-01-24 11:03:31 UTC
Pushed for 25.05!

Well done everyone, thank you!