Created attachment 175653 [details] [review] Bug 38744: Wrap tests in Biblio.t inside a transaction Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I'm getting the sha1/fake ancestor error when I try to apply the patch: git bz apply 38744 Bug 38744 - Tests in Koha/Biblio.t are not rolling back 175653 - Bug 38744: Wrap tests in Biblio.t inside a transaction Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38744: Wrap tests in Biblio.t inside a transaction error: sha1 information is lacking or useless (t/db_dependent/Koha/Biblio.t). error: could not build fake ancestor Patch failed at 0001 Bug 38744: Wrap tests in Biblio.t inside a transaction ...
Created attachment 176883 [details] [review] Bug 38744: Wrap tests in Biblio.t inside a transaction Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 176887 [details] [review] Bug 38744: Wrap tests in Biblio.t inside a transaction Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Thanks Tomás! Tests pass before and after the patch: t/db_dependent/Koha/Biblio.t David
Created attachment 176894 [details] [review] Bug 38744: Wrap tests in Biblio.t inside a transaction Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 176895 [details] [review] Bug 38744: Add more missing txn Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Jonathan Druart from comment #7) > > Created attachment 176895 [details] [review] [review] > Bug 38744: Add more missing txn This feels like chasing a TGV.
(In reply to Tomás Cohen Arazi (tcohen) from comment #8) > (In reply to Jonathan Druart from comment #7) > > > > Created attachment 176895 [details] [review] [review] [review] > > Bug 38744: Add more missing txn > > This feels like chasing a TGV. They actually predate your patch :D
Thanks for tracking these down!
Pushed for 25.05! Well done everyone, thank you!