Bug 38755 - search_for_data_inconsistencies.pl: Fix list of inconsistencies
Summary: search_for_data_inconsistencies.pl: Fix list of inconsistencies
Status: BLOCKED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 36027
Blocks:
  Show dependency treegraph
 
Reported: 2024-12-19 14:36 UTC by Magnus Enger
Modified: 2024-12-23 12:26 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38755: search_for_data_inconsistencies.pl: Fix list of inconsistencies (2.30 KB, patch)
2024-12-23 09:18 UTC, Magnus Enger
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2024-12-19 14:36:08 UTC
The relevant POD looks like this: 

-----------------------------------------------------

=head1 DESCRIPTION

Catch data inconsistencies in Koha database

* Items with undefined homebranch and/or holdingbranch
* Authorities with undefined authtypecodes/authority types
* Item types:
  * if item types are defined at item level (item-level_itypes=specific item),
    then items.itype must be set else biblioitems.itemtype must be set
  * Item types defined in items or biblioitems must be defined in the itemtypes table
* Invalid MARCXML in bibliographic records
* Patrons with invalid category types due to lower and upper age limits
* Any date fields in the database (timestamp, datetime, date) set to 0000-00-00

=cut

-----------------------------------------------------

perldoc renders the list as running text, which is kind of hard to read. The list should either be formatted with "=item" or indented to be treated as "pre formatted" chunk of text. I would vote for the first option.
Comment 1 Magnus Enger 2024-12-23 09:18:11 UTC
Created attachment 175908 [details] [review]
Bug 38755: search_for_data_inconsistencies.pl: Fix list of inconsistencies

To reproduce:
- Run "perldoc misc/maintenance/search_for_data_inconsistencies.pl"
- Verify the list of inconsistencies is rendered as running text

To test:
- Apply this patch
- Run "perldoc misc/maintenance/search_for_data_inconsistencies.pl"
- Verify the list of inconsistencies is now rendered as a bulleted
  list, with two list elements correctly indented
Comment 2 Magnus Enger 2024-12-23 12:26:34 UTC
This patch conflicts with patches on bug 36027. Let's get that bug in before we fix this one.