Bug 38792 - Move "My virtual card" tab and maybe re-label it
Summary: Move "My virtual card" tab and maybe re-label it
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Paul Derscheid
URL:
Keywords:
: 38791 (view as bug list)
Depends on: 39411 26777
Blocks:
  Show dependency treegraph
 
Reported: 2024-12-27 20:40 UTC by Katrin Fischer
Modified: 2025-06-24 21:52 UTC (History)
8 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 38792: Rename "My virtual card" to "Library card" and move tab (8.91 KB, patch)
2025-05-19 14:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38792: Rename "My virtual card" to "Library card" and move tab (8.96 KB, patch)
2025-05-19 17:54 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 39411: Add cardnumber and dateexpiry to OPAC virtual card (2.22 KB, patch)
2025-05-20 12:30 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 38792: Rename "My virtual card" to "Library card" and move tab (9.02 KB, patch)
2025-05-20 12:30 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 38792: Rename "My virtual card" to "Library card" and move tab (9.02 KB, patch)
2025-06-14 13:49 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2024-12-27 20:40:02 UTC
When pushing bug 26777 I had made these notes on the bug:

> 1) Naming and positioning
> 
> This is a question: You named the tab "My virtual card", but that appears
> very general. What about we named it "Library card" or "Virtual library
> card" instead? 
> Tbh I struggle a bit with the 'virtual and the "my" that we once had removed
> from all the other tabs.
> 
> Also, right now the tab appears last in the patron's account, should we move
> it to be first or second?

I believe they still apply and we should at least move the feature more to the top of the tabs.
Comment 1 Aude Charillon 2025-02-14 15:02:25 UTC
I was surprised when playing with the new feature that the tab was called "MY virtual card". I agree this doesn't fit with the other tabs that do not use "my" anymore.

I think it's obvious the card is virtual. My preference would be for the tab to be renamed "Library card".

I also agree it would make more sense to have that tab further up in the tab list, either right after the Summary or right after Personal details.
Comment 2 Katrin Fischer 2025-02-14 16:19:04 UTC
Thanks Aude!
Comment 3 Roman Dolny 2025-02-14 16:45:58 UTC
Virtual card is very useful and IMO should be renamed to "Library card".

I think the tab should be last on the list - because of the way the user uses it on the cell phone (which is primary purpose of "Library card").
When the user logs in on the mobile device at the lending room (needs the barcode/QR there), sees his/her account (orders, rentals) first, and only below it the list of tabs. It is more convenient to scroll to the end of the screen (one fast scroll) and click on the last card, rather than looking for that tab in the middle of the list, scrolling slowly through the screen.
Comment 4 Katrin Fischer 2025-02-14 17:07:36 UTC
What about making it first?
Comment 5 Roman Dolny 2025-02-15 11:06:21 UTC
(In reply to Katrin Fischer from comment #4)
> What about making it first?

Doesn't seem right to me because of desktop users.
Comment 6 David Cook 2025-02-16 23:21:12 UTC
(In reply to Roman Dolny from comment #5)
> (In reply to Katrin Fischer from comment #4)
> > What about making it first?
> 
> Doesn't seem right to me because of desktop users.

A while ago, I implemented this same functionality using a Koha plugin. What I do is render "Your barcode" beneath "Your summary" and have a little "barcode" icon next to the person icon next to "Welcome, X Person".

We used to use a tab on the opac-user.pl navigation but we found it unnecessary when we added it to those 2 other places instead. (Basically, we were looking to reduce "friction", so that users could make as few interactions as possible in order to get their barcode up for a self-checkout.)

We still render them on a desktop, and I don't think there have been any complaints, but a person could hide them using CSS and/or Javascript.
Comment 7 Jake Deery 2025-02-18 13:37:18 UTC
My pennies worth: I think the labelling is inconsistent and the positioning is wrong. I can't really say what I think the label should be – Library Card perhaps? All I know for sure is that I feel the “my” should be gone.

As for the positioning, this much is a lot easier for me: I don't like it, and feel that it should be near the top. There should be more places to access it (one in the account dropdown, perhaps, and one in the Summary page), and it should sit directly under Summary in the list, in my view.

If you look at the screenshot below (taken on iPhone 13), when scrolled 100% to the bottom, the whole list can be seen. A change does not impact mobile users.

https://i.imgur.com/VB4bzVe.png 

If you look at the screenshot below (taken on a 1024×768 display), the my virtual card button is obscured. If a sysadmin has taken the effort of enabling this syspref, they likely see this feature as quite important.

https://i.imgur.com/RkhuiTj.png

Hope my opinions help.
Jake
Comment 8 Owen Leonard 2025-05-19 14:55:53 UTC
*** Bug 38791 has been marked as a duplicate of this bug. ***
Comment 9 Owen Leonard 2025-05-19 14:56:42 UTC Comment hidden (obsolete)
Comment 10 Roman Dolny 2025-05-19 17:54:53 UTC Comment hidden (obsolete)
Comment 11 Paul Derscheid 2025-05-20 12:30:49 UTC Comment hidden (obsolete)
Comment 12 Paul Derscheid 2025-05-20 12:30:52 UTC Comment hidden (obsolete)
Comment 13 Paul Derscheid 2025-05-20 12:34:16 UTC
This is PQA in my opinion.

I think there are some points in the discussion that are worth exploring further, e.g. more options to access it.

Within the scope of this bug, the changes make sense and should be pushed. The base for iteration is there.
Comment 14 Katrin Fischer 2025-05-20 12:42:49 UTC
Dependency is not signed off yet - bug 39411.
Comment 15 Aude Charillon 2025-05-20 12:51:39 UTC
The move and renaming look good :-)
Comment 16 David Cook 2025-05-20 23:43:10 UTC
(In reply to Paul Derscheid from comment #13)
> This is PQA in my opinion.
> 
> I think there are some points in the discussion that are worth exploring
> further, e.g. more options to access it.
> 
> Within the scope of this bug, the changes make sense and should be pushed.
> The base for iteration is there.

(In reply to Katrin Fischer from comment #14)
> Dependency is not signed off yet - bug 39411.

Looks like Paul PQAed bug 39411 after Katrin commented, so I'll move this back to Passed QA.
Comment 17 Lucas Gass (lukeg) 2025-06-13 19:18:51 UTC
Owen, there are two attachments here with different bug numbers in the commit messages. Can you have a look?
Comment 18 Owen Leonard 2025-06-14 13:49:20 UTC
Created attachment 183257 [details] [review]
Bug 38792: Rename "My virtual card" to "Library card" and move tab

This patch makes a number of changes to the "My virtual card" page and
associated menu item:

1. Rename it to "Library card." This fits better with the naming of
   other user pages. This change includes updates to the page title,
   breadcrumb menu, and page heading.
2. Move the menu item up to appear right after the "Summary" link.
3. Make some style changes to the display of the card, giving the card
   more comfortable padding and adding some responsive behavior to the
   card width.

To test, apply the patch and rebuild the OPAC CSS.

- If necessary, go to Administration -> System preferences and enable
  the OPACVirtualCard preference.
- Log in to the OPAC.
- You should see a "Library card" menu item in the left-hand sidebar
  menu, right below the "Summary" item.
- On the "Library card" page, the page title, breadcrumb item, and page
  heading should read "Your library card."
- The "card" should look good, and should adjust well at various browser
  widths.
  - Above 769px wide, the card should not expand wider than 500px.
  - Below 769px wide, the card should have a width of 100% and should
    adjust as the viewport is narrowed.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 19 Owen Leonard 2025-06-14 13:50:14 UTC
(In reply to Lucas Gass (lukeg) from comment #17)
> Owen, there are two attachments here with different bug numbers in the
> commit messages. Can you have a look?

Accidentally attached the dependency, sorry!
Comment 20 Lucas Gass (lukeg) 2025-06-24 21:52:25 UTC
Nice work everyone!

Pushed to main for 25.11