Bug 38838 - optgroup construct needs cleaning in the reports module
Summary: optgroup construct needs cleaning in the reports module
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 38714
  Show dependency treegraph
 
Reported: 2025-01-07 09:22 UTC by Jonathan Druart
Modified: 2025-01-25 21:13 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement updates what is shown when selecting the columns when creating a new dictionary definition in reports. It now shows "Field description / tablename.fieldname", instead of just the "Field description" - the same as for creating reports. Example, 'Publication date / biblioitems.publicationyear' (previously it just showed 'Publication date').
Version(s) released in:
Circulation function:


Attachments
Bug 38838: Clean C4::Reports::Guided->get_columns (11.23 KB, patch)
2025-01-07 09:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38838: Clean C4::Reports::Guided->get_columns (11.27 KB, patch)
2025-01-25 21:00 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-01-07 09:22:31 UTC
reports/dictionary.tt and reports/guided_reports_start.tt display a list of the columns available using optgroup to group the columns per table.

The template code is quite ugly because of the perl structure choose in C4::Reports::Guided->get_columns
Comment 1 Jonathan Druart 2025-01-07 09:45:04 UTC
Created attachment 176170 [details] [review]
Bug 38838: Clean C4::Reports::Guided->get_columns

reports/dictionary.tt and reports/guided_reports_start.tt display a list
of the columns available using optgroup to group the columns per table.

The template code is quite ugly because of the perl structure choose in
C4::Reports::Guided->get_columns

This patch removes $cgi and the 'first' variable that were not used.
Now we have an usual structure with the table names as keys and column
info in an arrayref.

Test plan:
Create a report and a new dictionary definition.
At step 3 you should see the list of the columns.
Note that they are now identical. The list when you create a dictionary
now show the description of the columns.
Comment 2 David Nind 2025-01-25 21:00:09 UTC
Created attachment 177146 [details] [review]
Bug 38838: Clean C4::Reports::Guided->get_columns

reports/dictionary.tt and reports/guided_reports_start.tt display a list
of the columns available using optgroup to group the columns per table.

The template code is quite ugly because of the perl structure choose in
C4::Reports::Guided->get_columns

This patch removes $cgi and the 'first' variable that were not used.
Now we have an usual structure with the table names as keys and column
info in an arrayref.

Test plan:
Create a report and a new dictionary definition.
At step 3 you should see the list of the columns.
Note that they are now identical. The list when you create a dictionary
now show the description of the columns.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2025-01-25 21:13:31 UTC
Signed off and release note added.

I'm not sure about changing the formatting of the table group title from bold to bold and italic/emphasis. I think I prefer just the bold.