The descriptions for both OpacRenewalBranch and RESTAPIRenewalBranch system preferences are very vague. I know there is "Renewal" in the system preference names, but for translation, I think it would be best to have it in the description so that it's translated. Also, now that there are two, the sentences could be different to state what they are about. Currently, they both have this description: Use ___ as branchcode to store in the statistics table. OpacRenewalBranch could have this description: Use ___ as branchcode to store in the statistics table for renewals done in the OPAC. RESTAPIRenewalBranch could have this description: Use ___ as branchcode to store in the statistics table for renewals done through the REST API.
Created attachment 176280 [details] [review] Bug 38851: Rephrase OpacRenewalBranch and RESTAPIRenewalBranch to specify that they are about renewals This patch adds precision to the OpacRenewalBranch and RESTAPIRenewalBranch system preference descriptions to distinguish them from one another and to specify that they are about renewals. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for RenewalBranch 4. Read the descriptions for both OpacRenewalBranch and RESTAPIRenewalBranch, make sure they make sense and are correct english
Created attachment 176449 [details] [review] Bug 38851: Rephrase OpacRenewalBranch and RESTAPIRenewalBranch to specify that they are about renewals This patch adds precision to the OpacRenewalBranch and RESTAPIRenewalBranch system preference descriptions to distinguish them from one another and to specify that they are about renewals. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for RenewalBranch 4. Read the descriptions for both OpacRenewalBranch and RESTAPIRenewalBranch, make sure they make sense and are correct english Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>