Created attachment 176372 [details] 200 error When loading the bookings to collect report in the circulation module an error appears. 'Something went wrong when loading the table. 200:ok.
This one is showing as an enhancement, but it's a bug. What's the best way to re-classify it?
Kristi, one makes that change in the righthand dropdown under Importance. I've changed it from Enhancement to Normal, but you're welcome to bump it up if you feel it warranted. It looks like the report is still giving results, despite the error, so normal seemed fair to me. I see this error in the console when loading the page: DataTables warning: table id=bookingst - Requested unknown parameter 'pickup_library.name:me.pickup_library_id' for row 0, column 1. For more information about this error, please see https://datatables.net/tn/4
Normal sounds good. Thanks.
Created attachment 178838 [details] [review] Bug 38861: Use a render function to display pickup name or pickup ID To test: 0. Have some bookings that are ready to collect. 1. Load the bookings to collect report. 2. Table does not load. 3. APPLY PATCH 4. Try again, table loads. 5. Make sure you can filter by 'Pickup library'
Created attachment 178867 [details] [review] Bug 38861: Use a render function to display pickup name or pickup ID To test: 0. Have some bookings that are ready to collect. 1. Load the bookings to collect report. 2. Table does not load. 3. APPLY PATCH 4. Try again, table loads. 5. Make sure you can filter by 'Pickup library' Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org>
Created attachment 178931 [details] [review] Bug 38861: Use a render function to display pickup name or pickup ID To test: 0. Have some bookings that are ready to collect. 1. Load the bookings to collect report. 2. Table does not load. 3. APPLY PATCH 4. Try again, table loads. 5. Make sure you can filter by 'Pickup library' Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Interesting.. this is a good solution to cover where a pickup library may not exist for some reason.. that's a surprise to me, but it perhaps a left over data artifact from an early use of bookings before the pickup library functionality was added. Thanks for the improvement regardless Lucas Passing QA
Pushed for 25.05! Well done everyone, thank you!