Bug 38861 - Error loading the table in the bookings to collect report
Summary: Error loading the table in the bookings to collect report
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-10 16:53 UTC by Jessie Zairo
Modified: 2025-03-26 19:58 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This patch fixes a bug where the bookings to collect table was not loading correctly.
Version(s) released in:
25.05.00
Circulation function:


Attachments
200 error (393.92 KB, image/png)
2025-01-10 16:53 UTC, Jessie Zairo
Details
Bug 38861: Use a render function to display pickup name or pickup ID (1.31 KB, patch)
2025-02-28 15:12 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38861: Use a render function to display pickup name or pickup ID (1.37 KB, patch)
2025-02-28 16:23 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 38861: Use a render function to display pickup name or pickup ID (1.43 KB, patch)
2025-03-04 16:48 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Zairo 2025-01-10 16:53:23 UTC Comment hidden (obsolete)
Comment 1 Kristi 2025-02-17 20:04:40 UTC
This one is showing as an enhancement, but it's a bug. What's the best way to re-classify it?
Comment 2 Andrew Fuerste-Henry 2025-02-27 19:34:25 UTC
Kristi, one makes that change in the righthand dropdown under Importance. I've changed it from Enhancement to Normal, but you're welcome to bump it up if you feel it warranted.
It looks like the report is still giving results, despite the error, so normal seemed fair to me.

I see this error in the console when loading the page: 
DataTables warning: table id=bookingst - Requested unknown parameter 'pickup_library.name:me.pickup_library_id' for row 0, column 1. For more information about this error, please see https://datatables.net/tn/4
Comment 3 Kristi 2025-02-27 21:09:51 UTC
Normal sounds good. Thanks.
Comment 4 Lucas Gass (lukeg) 2025-02-28 15:12:27 UTC
Created attachment 178838 [details] [review]
Bug 38861: Use a render function to display pickup name or pickup ID

To test:
0. Have some bookings that are ready to collect.
1. Load the bookings to collect report.
2. Table does not load.
3. APPLY PATCH
4. Try again, table loads.
5. Make sure you can filter by 'Pickup library'
Comment 5 Andrew Fuerste-Henry 2025-02-28 16:23:13 UTC Comment hidden (obsolete)
Comment 6 Martin Renvoize (ashimema) 2025-03-04 16:48:51 UTC Comment hidden (obsolete)
Comment 7 Martin Renvoize (ashimema) 2025-03-04 16:50:12 UTC
Interesting.. this is a good solution to cover where a pickup library may not exist for some reason.. that's a surprise to me, but it perhaps a left over data artifact from an early use of bookings before the pickup library functionality was added.

Thanks for the improvement regardless Lucas

Passing QA
Comment 8 Katrin Fischer 2025-03-10 10:45:33 UTC
Pushed for 25.05!

Well done everyone, thank you!