Bug 38877 - Improve translation of title tags: OPAC part 3
Summary: Improve translation of title tags: OPAC part 3
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: RM_priority
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2025-01-13 19:41 UTC by Owen Leonard
Modified: 2025-05-15 07:18 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38877: Improve translation of title tags: OPAC part 3 (24.84 KB, patch)
2025-03-05 17:21 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38877: Improve translation of title tags: OPAC part 3 (24.85 KB, patch)
2025-05-09 23:26 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-01-13 19:41:18 UTC
This patch will modify more OPAC templates so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2025-03-05 17:21:33 UTC
Created attachment 178998 [details] [review]
Bug 38877: Improve translation of title tags: OPAC part 3

This patch updates a batch of OPAC templates so that title tags can
be more easily translated.

To test, apply the patch and confirm that the following pages have
correct title tags:

As a user logged in to the OPAC:
- Change password (with OpacPasswordChange enabled)
- Privacy management (with OPACPrivacy enabled)
- Checkout history (with opacreadinghistory enabled)
- Search history (with EnableOpacSearchHistory enabled)
- Consent (set PrivacyPolicyConsent to "enforced")
- Place a recall (with UseRecalls enabled and recalls configured in
  Circulation & Fine rules)
  - View your recalls
- Place a hold
- Request and article (with ArticleRequests enabled and configured in
  Circulation & Fine rules)
- Submit a comment (with OPACComments enabled)
- View your routing lists (with RoutingSerials enabled):
  - In the staff interface, search for a subscription
  - View the subscription details
  - Click "Create routing list" in the sidebar
  - Add yourself to the recipients list
  - Return to the OPAC and view the routing lists page

Check these pages too:
- http://localhost:8080/cgi-bin/koha/opac-restrictedpage.pl
- Catalog search results
- Report a problem (with OPACReportProblem enabled)
- Password recovery (with OpacResetPassword enabled)
- Create an account (with PatronSelfRegistration enabled)
  - Test with PatronSelfRegistrationConfirmEmail enabled.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2025-05-09 23:26:38 UTC
Created attachment 182238 [details] [review]
Bug 38877: Improve translation of title tags: OPAC part 3

This patch updates a batch of OPAC templates so that title tags can
be more easily translated.

To test, apply the patch and confirm that the following pages have
correct title tags:

As a user logged in to the OPAC:
- Change password (with OpacPasswordChange enabled)
- Privacy management (with OPACPrivacy enabled)
- Checkout history (with opacreadinghistory enabled)
- Search history (with EnableOpacSearchHistory enabled)
- Consent (set PrivacyPolicyConsent to "enforced")
- Place a recall (with UseRecalls enabled and recalls configured in
  Circulation & Fine rules)
  - View your recalls
- Place a hold
- Request and article (with ArticleRequests enabled and configured in
  Circulation & Fine rules)
- Submit a comment (with OPACComments enabled)
- View your routing lists (with RoutingSerials enabled):
  - In the staff interface, search for a subscription
  - View the subscription details
  - Click "Create routing list" in the sidebar
  - Add yourself to the recipients list
  - Return to the OPAC and view the routing lists page

Check these pages too:
- http://localhost:8080/cgi-bin/koha/opac-restrictedpage.pl
- Catalog search results
- Report a problem (with OPACReportProblem enabled)
- Password recovery (with OpacResetPassword enabled)
- Create an account (with PatronSelfRegistration enabled)
  - Test with PatronSelfRegistrationConfirmEmail enabled.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2025-05-09 23:31:19 UTC
Testing notes (using KTD):
1. Everything looks OK, but I didn't install another language and check that the strings are available for translation.
2. I ran the qa script - everything says OK.
3. I had a quick look at the patch, but I'm not sure exactly what I'm looking for 8-)

Inconsistencies
===============

There are some inconsistencies between the breadcrumbs, page titles, and browser titles. However, these are the same before and after the patch. So another bug if these should be fixed up at some stage.

Some inconsistencies
--------------------

- Personal details: breadcrumb and page title - Your personal details; browser title - Update your personal details
- Tags: breadcrumb and browser title - Tags; page title - All tags
- Search history: breadcrumb and browser title - Your search history; page title - Search history
- Checkout history: breadcrumb and browser title - Your checkout history; page title - Checkout history
- Recalls history: breadcrumb and browser title - Your recalls history; page title - Recalls history
- Purchase suggestions: breadcrumb and browser title - Purchase suggestions; page title - Your purchase suggestions
- Lists: breadcrumb and page title - Lists; browser title - Your lists
- Self-registration:
  . Form to register:
    . Breadcrumb: Home > Register a new account
    . Page title: Your personal details
    . Browser page title: Register a new account
  . Once completed registration:
    . Breadcrumb: Home > Registration complete
    . Page title: Registration complete!
     . Browser page title: Koha online catalog - [browser name]

All consistent
--------------

- Summary: breadcrumb, page title, and browser title - Your summary
- Charges: breadcrumb, page title, and browser title - charges
- Consents: breadcrumb, page title, and browser title - Your consents
- Change password: breadcrumb, page title, and browser title - Change your password
- Privacy: breadcrumb, page title, and browser title - Your privacy management
- Messaging: breadcrumb, page title, and browser title - Your messaging settings

QA script results
=================
qa
testing 1 commit(s) (applied to 1941a0c '7e Bug 39011: (follow-up) Update sele')

Processing files before patches
|========================>| 19 / 19 (100.00%)
Processing files after patches
|========================>| 19 / 19 (100.00%)

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-patron-consent.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-email-sent.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-invalid.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-restrictedpage.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-routing-lists.tt

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt


Processing additional checks OK!