Bug 38928 - Openurl 'id' or 'rft_id' may contain key information
Summary: Openurl 'id' or 'rft_id' may contain key information
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-20 13:31 UTC by Pedro Amorim
Modified: 2025-01-20 13:35 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38928: Handle rft_id or id (2.43 KB, patch)
2025-01-20 13:35 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2025-01-20 13:31:50 UTC
Currently, the Standard backend is mapping 'id' or 'rft_id' in the openurl to 'doi'.

But 'rft_id' may contain  'DOI:12345' where '12345' is the doi value.
Comment 1 Pedro Amorim 2025-01-20 13:32:36 UTC
Currently, the Standard backend is mapping 'id' or 'rft_id' in the openurl to 'doi'.

But 'id' or 'rft_id' may contain  'DOI:12345' where '12345' is the doi value.
Comment 2 Pedro Amorim 2025-01-20 13:35:45 UTC
Created attachment 176807 [details] [review]
Bug 38928: Handle rft_id or id

If a semicolon exists, the key should be what's before the semicolon, and its value, whats the after.
Otherwise, default to 'doi' as it was before.

To test:
1) Enable ILLModule.
2) Visit the following URLs
http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=create&backend=Standard&openurl=1&genre=article&id=10.1016/j.cognition.2024.105913
http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=create&backend=Standard&openurl=1&genre=article&id=doi:10.1016/j.cognition.2024.105913
3) Notice that in both cases, only the doi value '10.1016/j.cognition.2024.105913' should be present in the input.