Bug 38935 - "Actions" column not translatable for the item search results table (itemsearch.tt)
Summary: "Actions" column not translatable for the item search results table (itemsear...
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Emmi Takkinen
QA Contact: Testopia
URL:
Keywords:
Depends on: 37238
Blocks:
  Show dependency treegraph
 
Reported: 2025-01-21 10:49 UTC by Emmi Takkinen
Modified: 2025-02-07 18:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the item search results table in the staff interface - the "Actions" column label is now translatable.
Version(s) released in:
25.05.00,24.11.02
Circulation function:


Attachments
Bug 38935: Actions column not translatable in itemsearch.tt (1.66 KB, patch)
2025-01-21 11:05 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 38935: Actions column not translatable in itemsearch.tt (1.70 KB, patch)
2025-01-22 18:23 UTC, David Nind
Details | Diff | Splinter Review
Bug 38935: Actions column not translatable in itemsearch.tt (1.78 KB, patch)
2025-01-23 11:42 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emmi Takkinen 2025-01-21 10:49:35 UTC
Column "Actions" is not translatable in itemsearch.tt. There is also typo in this columns id.
Comment 1 Emmi Takkinen 2025-01-21 11:05:44 UTC
Created attachment 176854 [details] [review]
Bug 38935: Actions column not translatable in itemsearch.tt

Column "Actions" was not translatable in itemsearch.tt. This
patch makes column translatable. This also fixes typo in this
columns id.

Test plan:
1. Change language as something else than english.
2. Navigate to "Item search" page and search for items.
=> Note that column "Actions" still reads "Actions"
3. Apply this patch.
4. Make new item search.
=> Column should now have correct translation.
Comment 2 David Nind 2025-01-22 18:23:59 UTC
Created attachment 176925 [details] [review]
Bug 38935: Actions column not translatable in itemsearch.tt

Column "Actions" was not translatable in itemsearch.tt. This
patch makes column translatable. This also fixes typo in this
columns id.

Test plan:
1. Change language as something else than english.
2. Navigate to "Item search" page and search for items.
=> Note that column "Actions" still reads "Actions"
3. Apply this patch.
4. Make new item search.
=> Column should now have correct translation.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2025-01-22 18:29:16 UTC
Testing notes (using KTD):

1. Install a language: koha-translate --install de-DE --dev kohadev
2. Enable the language: Koha administration > System preferences > I18NL10N > StaffInterfaceLanguages
3. For German, note that the "Actions" column is still labeleld as "Actions", instead of "Aktionen"
3. After the patch is applied:
   - Update the translation .po files with the new strings: gulp po:update --lang de-DE
   - Install the updated transaltion: koha-translate --update de-DE --dev kohadev
4. Column label for the "Actions" column is now correctly translated.
Comment 4 Jonathan Druart 2025-01-23 11:42:41 UTC
Created attachment 176950 [details] [review]
Bug 38935: Actions column not translatable in itemsearch.tt

Column "Actions" was not translatable in itemsearch.tt. This
patch makes column translatable. This also fixes typo in this
columns id.

Test plan:
1. Change language as something else than english.
2. Navigate to "Item search" page and search for items.
=> Note that column "Actions" still reads "Actions"
3. Apply this patch.
4. Make new item search.
=> Column should now have correct translation.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Katrin Fischer 2025-01-24 11:03:57 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 6 Paul Derscheid 2025-02-04 21:54:56 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.02