Bug 38966 - Wrong POD in Koha/CoverImages.pm and Koha/Acquisition/Order/Claims.pm
Summary: Wrong POD in Koha/CoverImages.pm and Koha/Acquisition/Order/Claims.pm
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Doris Tam
QA Contact: Marcel de Rooy
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2025-01-24 18:50 UTC by Nick Clemens (kidclamp)
Modified: 2025-08-01 12:55 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.02,24.11.08
Circulation function:


Attachments
Bug 38966: Fix wrong POD in Koha/CoverImages.pm and Koha/Acquisition/Order/Claims.pm (1.32 KB, patch)
2025-07-17 23:24 UTC, Doris Tam
Details | Diff | Splinter Review
Bug 38966: Fix wrong POD in Koha/CoverImages.pm and Koha/Acquisition/Order/Claims.pm (1.32 KB, patch)
2025-07-17 23:29 UTC, Doris Tam
Details | Diff | Splinter Review
Bug 38966: Fix wrong POD in Koha/CoverImages.pm and Koha/Acquisition/Order/Claims.pm (1.37 KB, patch)
2025-07-18 02:04 UTC, David Nind
Details | Diff | Splinter Review
Bug 38966: Fix wrong POD in Koha/CoverImages.pm and Koha/Acquisition/Order/Claims.pm (1.46 KB, patch)
2025-07-18 06:33 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2025-01-24 18:50:47 UTC
git grep "Cities"

Koha/Acquisition/Order/Claims.pm:Koha::Cities - Koha Claim Object set class
Koha/CoverImages.pm:Koha::Cities - Koha CoverImage Object set class


copy paste error :-)
Comment 1 Doris Tam 2025-07-17 23:24:15 UTC Comment hidden (obsolete)
Comment 2 Doris Tam 2025-07-17 23:29:02 UTC Comment hidden (obsolete)
Comment 3 David Nind 2025-07-18 02:04:41 UTC
Created attachment 184270 [details] [review]
Bug 38966: Fix wrong POD in Koha/CoverImages.pm and Koha/Acquisition/Order/Claims.pm

Test plan:
1. perldoc Koha/Acquisition/Order/Claims.pm
2. Check that it mentions Koha::Acquisition::Order::Claims
3. perldoc Koha/CoverImages.pm
4. Check that it mentions Koha::CoverImages.pm
4. These files no longer mention 'Koha::Cities'

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-07-18 02:05:45 UTC
Thanks for the patch Doris!
Comment 5 Marcel de Rooy 2025-07-18 06:33:22 UTC
Created attachment 184277 [details] [review]
Bug 38966: Fix wrong POD in Koha/CoverImages.pm and Koha/Acquisition/Order/Claims.pm

Test plan:
1. perldoc Koha/Acquisition/Order/Claims.pm
2. Check that it mentions Koha::Acquisition::Order::Claims
3. perldoc Koha/CoverImages.pm
4. Check that it mentions Koha::CoverImages.pm
4. These files no longer mention 'Koha::Cities'

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Lucas Gass (lukeg) 2025-07-18 17:11:37 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 7 Paul Derscheid 2025-07-24 08:19:56 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 8 Fridolin Somers 2025-08-01 12:55:04 UTC
Pushed to 24.11.x for 24.11.08