A discerning librarian of mine pointed out that the moremember.pl page shows "Card number" and "Borrowernumber". They asked for a space to be added to make the latter "Borrower number", which honestly makes a lot of sense. While I think that's a good starting point, I figured I'd raise this issue to cover all the different instances for both. $ grep -R "Card number" koha-tmpl/* | wc -l 36 $ grep -R "Cardnumber" koha-tmpl/* | wc -l 7 $ grep -R "Borrowernumber" koha-tmpl/* | wc -l 11 $ grep -R "Borrower number" koha-tmpl/* | wc -l 1 Chances are that there are more instances with lower cased initial letters, but cardnumber and borrowernumber are valid in links... It would probably be wise to add a coding guideline for this as well.
Although it's not on our Terminology page (https://wiki.koha-community.org/wiki/Terminology), we've had discussions about it before. "cardnumber" as one word is incorrect unless it's referring specifically to a database column. "borrowernumber" always refers to a database column, and thus has been kept as one word where it is shown to the user. Separating it into "Borrower number" would be confusing because we don't use the word "borrower" in the default American English templates to refer to patrons. Some of the instances of "borrowernumber" in the staff interface templates are part of operations where the user knows that borrowernumber is a database column because they're doing an import of some kind (tools/modborrowers.t, patron_lists/list.tt). Originally the patron detail pages did not show the borrowernumber on the assumption that it wasn't relevant, but it was later requested that it be added to the display.
(In reply to Owen Leonard from comment #1) > Although it's not on our Terminology page > (https://wiki.koha-community.org/wiki/Terminology), we've had discussions > about it before. In that case, it sounds like "Borrower number" in koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt should become "Borrowernumber"? And "Cardnumbers" in koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt should become "Card numbers"? I suppose this one is debateable. I reckon it might be worth putting into the Terminology in any case. (In reply to Owen Leonard from comment #1) > Originally the patron detail pages did not show the borrowernumber on the > assumption that it wasn't relevant, but it was later requested that it be > added to the display. That does sound familiar now that you mention it. One day I'd love to transition from borrowernumber to UUID for security purposes and then it'll get even more interesting...
Created attachment 177708 [details] [review] Bug 38979: Correct instances of "cardnumber" to "card number" The patron list detail page template has several instances of "cardnumber" which should be corrected to "card number." To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary. - When viewing the patron list, click "Add multiple patrons." - Under "Choose type of IDs to enter," you should see "Card numbers". - Add some patrons to the list. - Try to add one or more of the same patrons to the list using the "Add multiple patrons" link.. - You should see a warning message, "Warning, the following card numbers..." - The table showing the duplicate card numbers should have the heading "Card numbers already in list". - Use the "Add multiple patrons" link to add card numbers which do not exist. - You should see a warning message, "Warning, the following card numbers..." - The table showing the unknown card numbers should have the heading "Card numbers not found". Sponsored-by: Athens County Public Libraries
Created attachment 177944 [details] [review] Bug 38979: Correct instances of "cardnumber" to "card number" The patron list detail page template has several instances of "cardnumber" which should be corrected to "card number." To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary. - When viewing the patron list, click "Add multiple patrons." - Under "Choose type of IDs to enter," you should see "Card numbers". - Add some patrons to the list. - Try to add one or more of the same patrons to the list using the "Add multiple patrons" link.. - You should see a warning message, "Warning, the following card numbers..." - The table showing the duplicate card numbers should have the heading "Card numbers already in list". - Use the "Add multiple patrons" link to add card numbers which do not exist. - You should see a warning message, "Warning, the following card numbers..." - The table showing the unknown card numbers should have the heading "Card numbers not found". Sponsored-by: Athens County Public Libraries
Created attachment 177945 [details] [review] Bug 38979: Correct instances of "cardnumber" to "card number" The patron list detail page template has several instances of "cardnumber" which should be corrected to "card number." To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary. - When viewing the patron list, click "Add multiple patrons." - Under "Choose type of IDs to enter," you should see "Card numbers". - Add some patrons to the list. - Try to add one or more of the same patrons to the list using the "Add multiple patrons" link.. - You should see a warning message, "Warning, the following card numbers..." - The table showing the duplicate card numbers should have the heading "Card numbers already in list". - Use the "Add multiple patrons" link to add card numbers which do not exist. - You should see a warning message, "Warning, the following card numbers..." - The table showing the unknown card numbers should have the heading "Card numbers not found". Sponsored-by: Athens County Public Libraries
Created attachment 178117 [details] [review] Bug 38979: Correct instances of "cardnumber" to "card number" The patron list detail page template has several instances of "cardnumber" which should be corrected to "card number." To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary. - When viewing the patron list, click "Add multiple patrons." - Under "Choose type of IDs to enter," you should see "Card numbers". - Add some patrons to the list. - Try to add one or more of the same patrons to the list using the "Add multiple patrons" link.. - You should see a warning message, "Warning, the following card numbers..." - The table showing the duplicate card numbers should have the heading "Card numbers already in list". - Use the "Add multiple patrons" link to add card numbers which do not exist. - You should see a warning message, "Warning, the following card numbers..." - The table showing the unknown card numbers should have the heading "Card numbers not found". Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
I've added to the Terminology page in the wiki as proposed term changes https://wiki.koha-community.org/wiki/Terminology I've added to the next documentation meeting for approval.
I notice that for the table (and other tables0, and not related to this bug, that the column label is "Card". This seems wrong to me, and I think it should be "Card number".
Created attachment 178447 [details] [review] Bug 38979: Correct instances of "cardnumber" to "card number" The patron list detail page template has several instances of "cardnumber" which should be corrected to "card number." To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary. - When viewing the patron list, click "Add multiple patrons." - Under "Choose type of IDs to enter," you should see "Card numbers". - Add some patrons to the list. - Try to add one or more of the same patrons to the list using the "Add multiple patrons" link.. - You should see a warning message, "Warning, the following card numbers..." - The table showing the duplicate card numbers should have the heading "Card numbers already in list". - Use the "Add multiple patrons" link to add card numbers which do not exist. - You should see a warning message, "Warning, the following card numbers..." - The table showing the unknown card numbers should have the heading "Card numbers not found". Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 25.05! Well done everyone, thank you!