Bug 38994 - Class up the circulation homepage
Summary: Class up the circulation homepage
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Andrew Fuerste-Henry
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-29 20:05 UTC by Andrew Fuerste-Henry
Modified: 2025-02-21 11:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38994: Add classes to circulation module homepage (18.04 KB, patch)
2025-01-29 20:26 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2025-01-29 20:05:09 UTC
There aren't distinct html classes on the various sections and buttons on /cgi-bin/koha/circ/circulation-home.pl and it makes things hard to target with CSS.
Comment 1 Andrew Fuerste-Henry 2025-01-29 20:26:41 UTC
Created attachment 177319 [details] [review]
Bug 38994: Add classes to circulation module homepage

To test:
1: inspect /koha/circ/circulation-home.pl, see most elements lack distinct classes
2: apply patch, reload page
3: inspect page again, confirm nothing has changed in display
4: confirm page elements have distinct classes now and can be accurately targetted with CSS
Comment 2 Emmi Takkinen 2025-02-21 11:44:39 UTC
Applying patches produces following error:

Applying: Bug 38994: Add classes to circulation module homepage
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 38994: Add classes to circulation module homepage
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-38994-Add-classes-to-circulation-module-homepa-xIUMjF.patch