Bug 39005 - Typo in patron category 'Force new password reset' hintq
Summary: Typo in patron category 'Force new password reset' hintq
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Nicolas Hunstein
QA Contact: Tomás Cohen Arazi (tcohen)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-31 10:03 UTC by Aude Charillon
Modified: 2025-03-19 10:56 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39005: update the explanatory message of Force new patron password reset in the patron category form (1.97 KB, patch)
2025-02-28 13:48 UTC, Nicolas Hunstein
Details | Diff | Splinter Review
Bug 39005: update the explanatory message of Force new patron password reset in the patron category form (2.07 KB, patch)
2025-02-28 14:54 UTC, Nicolas Hunstein
Details | Diff | Splinter Review
Bug 39005: update the explanatory message of Force new patron password reset in the patron category form (2.13 KB, patch)
2025-03-03 17:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39005: update the explanatory message of Force new patron password reset in the patron category form (2.18 KB, patch)
2025-03-11 13:18 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aude Charillon 2025-01-31 10:03:37 UTC
Bug 33462 introduced, in the patron category administration pages, an option regarding forcing a new patron to reset their password - Force new patron password reset. However, there is a typo / grammar issue in the explanatory message underneath the pick field.

The message currently says: "Choose whether staff created patrons of this category be forced into resetting their password after their first OPAC login." It should be corrected to: "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login."
Comment 1 Nicolas Hunstein 2025-02-28 13:48:21 UTC
Created attachment 178834 [details] [review]
Bug 39005: update the explanatory message of Force new patron password reset in the patron category form

updates explanatory message "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login" to "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login"

to test:
- go to Administration page
- go to patron categories
- open the patron category form for example by clicking on "New category"
- check there is the string "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login"

- apply patch
- verify there is the string "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login" now
Comment 2 Aude Charillon 2025-02-28 14:27:57 UTC
I used a sandbox, and followed the steps from the test plan. After applying the patch, I observed that:

- The message within the patron category settings for "Force new patron password reset" has not been updated.

- The updated version of the message appears at the top of the Administration > Patron categories page, above the New category button. There is also text from the "Block expired patron OPAC actions" section.

Marking as Failed QA.
Comment 3 Katrin Fischer 2025-02-28 14:31:06 UTC
(In reply to Aude Charillon from comment #2)
> I used a sandbox, and followed the steps from the test plan. After applying
> the patch, I observed that:
> 
> - The message within the patron category settings for "Force new patron
> password reset" has not been updated.
> 
> - The updated version of the message appears at the top of the
> Administration > Patron categories page, above the New category button.
> There is also text from the "Block expired patron OPAC actions" section.
> 
> Marking as Failed QA.

Hi Aude, something seems to be wrong there not stemming from the patch (if you look at the diff). Maybe a conflict when applying the patch on the sandbox?
Comment 4 Aude Charillon 2025-02-28 14:33:21 UTC
(In reply to Katrin Fischer from comment #3)
> Hi Aude, something seems to be wrong there not stemming from the patch (if
> you look at the diff). Maybe a conflict when applying the patch on the
> sandbox?

If I did it wrong, please do change the status back to Needs sign-off so someone else can have a go :-)
Comment 5 Katrin Fischer 2025-02-28 14:36:52 UTC
(In reply to Aude Charillon from comment #4)
> (In reply to Katrin Fischer from comment #3)
> > Hi Aude, something seems to be wrong there not stemming from the patch (if
> > you look at the diff). Maybe a conflict when applying the patch on the
> > sandbox?
> 
> If I did it wrong, please do change the status back to Needs sign-off so
> someone else can have a go :-)

I'll test too, give me a few minutes :)
Comment 6 Katrin Fischer 2025-02-28 14:39:01 UTC
There is a conflict indeed!
Comment 7 Nicolas Hunstein 2025-02-28 14:54:12 UTC
Created attachment 178836 [details] [review]
Bug 39005: update the explanatory message of Force new patron password reset in the patron category form

updates explanatory message "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login" to "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login"

to test:
- go to Administration page
- go to patron categories
- open the patron category form for example by clicking on "New category"
- check there is the string "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login"

- apply patch
- verify there is the string "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login" now
Comment 8 Owen Leonard 2025-03-03 17:44:39 UTC
Created attachment 178893 [details] [review]
Bug 39005: update the explanatory message of Force new patron password reset in the patron category form

updates explanatory message "Choose whether staff created patrons of
this category be forces into resetting their passwort after their first
OPAC login" to "Choose whether staff-created patrons of this category
are forced to change their password after their first OPAC login"

to test:
- go to Administration page
- go to patron categories
- open the patron category form for example by clicking on "New
  category"
- check there is the string "Choose whether staff created patrons of
  this category be forces into resetting their passwort after their
  first OPAC login"

- apply patch
- verify there is the string "Choose whether staff-created patrons of
  this category are forced to change their password after their first
  OPAC login" now

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 9 Tomás Cohen Arazi (tcohen) 2025-03-11 13:18:56 UTC
Created attachment 179164 [details] [review]
Bug 39005: update the explanatory message of Force new patron password reset in the patron category form

updates explanatory message "Choose whether staff created patrons of
this category be forces into resetting their passwort after their first
OPAC login" to "Choose whether staff-created patrons of this category
are forced to change their password after their first OPAC login"

to test:
- go to Administration page
- go to patron categories
- open the patron category form for example by clicking on "New
  category"
- check there is the string "Choose whether staff created patrons of
  this category be forces into resetting their passwort after their
  first OPAC login"

- apply patch
- verify there is the string "Choose whether staff-created patrons of
  this category are forced to change their password after their first
  OPAC login" now

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 10 Katrin Fischer 2025-03-19 10:56:29 UTC
Pushed for 25.05!

Well done everyone, thank you!