Bug 33462 introduced, in the patron category administration pages, an option regarding forcing a new patron to reset their password - Force new patron password reset. However, there is a typo / grammar issue in the explanatory message underneath the pick field. The message currently says: "Choose whether staff created patrons of this category be forced into resetting their password after their first OPAC login." It should be corrected to: "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login."
Created attachment 178834 [details] [review] Bug 39005: update the explanatory message of Force new patron password reset in the patron category form updates explanatory message "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login" to "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login" to test: - go to Administration page - go to patron categories - open the patron category form for example by clicking on "New category" - check there is the string "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login" - apply patch - verify there is the string "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login" now
I used a sandbox, and followed the steps from the test plan. After applying the patch, I observed that: - The message within the patron category settings for "Force new patron password reset" has not been updated. - The updated version of the message appears at the top of the Administration > Patron categories page, above the New category button. There is also text from the "Block expired patron OPAC actions" section. Marking as Failed QA.
(In reply to Aude Charillon from comment #2) > I used a sandbox, and followed the steps from the test plan. After applying > the patch, I observed that: > > - The message within the patron category settings for "Force new patron > password reset" has not been updated. > > - The updated version of the message appears at the top of the > Administration > Patron categories page, above the New category button. > There is also text from the "Block expired patron OPAC actions" section. > > Marking as Failed QA. Hi Aude, something seems to be wrong there not stemming from the patch (if you look at the diff). Maybe a conflict when applying the patch on the sandbox?
(In reply to Katrin Fischer from comment #3) > Hi Aude, something seems to be wrong there not stemming from the patch (if > you look at the diff). Maybe a conflict when applying the patch on the > sandbox? If I did it wrong, please do change the status back to Needs sign-off so someone else can have a go :-)
(In reply to Aude Charillon from comment #4) > (In reply to Katrin Fischer from comment #3) > > Hi Aude, something seems to be wrong there not stemming from the patch (if > > you look at the diff). Maybe a conflict when applying the patch on the > > sandbox? > > If I did it wrong, please do change the status back to Needs sign-off so > someone else can have a go :-) I'll test too, give me a few minutes :)
There is a conflict indeed!
Created attachment 178836 [details] [review] Bug 39005: update the explanatory message of Force new patron password reset in the patron category form updates explanatory message "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login" to "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login" to test: - go to Administration page - go to patron categories - open the patron category form for example by clicking on "New category" - check there is the string "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login" - apply patch - verify there is the string "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login" now
Created attachment 178893 [details] [review] Bug 39005: update the explanatory message of Force new patron password reset in the patron category form updates explanatory message "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login" to "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login" to test: - go to Administration page - go to patron categories - open the patron category form for example by clicking on "New category" - check there is the string "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login" - apply patch - verify there is the string "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login" now Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 179164 [details] [review] Bug 39005: update the explanatory message of Force new patron password reset in the patron category form updates explanatory message "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login" to "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login" to test: - go to Administration page - go to patron categories - open the patron category form for example by clicking on "New category" - check there is the string "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login" - apply patch - verify there is the string "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login" now Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed for 25.05! Well done everyone, thank you!