Bug 39020 - Search filters can't parse query in some instances
Summary: Search filters can't parse query in some instances
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Lisette Scheer
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-03 16:45 UTC by Lisette Scheer
Modified: 2025-02-20 17:38 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39020: Search filters can't parse query (1.41 KB, patch)
2025-02-03 16:50 UTC, Lisette Scheer
Details | Diff | Splinter Review
Bug 39020: Search filters can't parse query (1.46 KB, patch)
2025-02-03 21:57 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 39020: Search filters can't parse query (1.53 KB, patch)
2025-02-10 13:11 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39020: Add tests (2.89 KB, patch)
2025-02-10 13:11 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39020: Search filters can't parse query (1.54 KB, patch)
2025-02-12 17:55 UTC, Lisette Scheer
Details | Diff | Splinter Review
Bug 39020: Add tests (2.89 KB, patch)
2025-02-13 18:11 UTC, Lisette Scheer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lisette Scheer 2025-02-03 16:45:43 UTC
To recreate:
Turn on the SavedSearchFilters system preference
Go to advanced search, select a number of item types and search
Save the search
Enter a search term (such as power)
select the filter. Observe the following message:
Error: Unable to understand your search query, please rephrase and try again.
Comment 1 Lisette Scheer 2025-02-03 16:50:53 UTC
Created attachment 177471 [details] [review]
Bug 39020: Search filters can't parse query

1. Turn on the SavedSearchFilters system preference
2. Go to advanced search, select a number of item types and search
3. Save the search
4. Enter a search term (such as power)
5. select the filter. Observe the following message:
Error: Unable to understand your search query, please rephrase and try again.
6. Apply patch
7. Repeat steps 4 & 5, search should work as expected.
8. Sign off!
Comment 2 Roman Dolny 2025-02-03 21:57:55 UTC
Created attachment 177490 [details] [review]
Bug 39020: Search filters can't parse query

1. Turn on the SavedSearchFilters system preference
2. Go to advanced search, select a number of item types and search
3. Save the search
4. Enter a search term (such as power)
5. select the filter. Observe the following message:
Error: Unable to understand your search query, please rephrase and try again.
6. Apply patch
7. Repeat steps 4 & 5, search should work as expected.
8. Sign off!

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Jonathan Druart 2025-02-10 13:11:13 UTC
Created attachment 177689 [details] [review]
Bug 39020: Search filters can't parse query

1. Turn on the SavedSearchFilters system preference
2. Go to advanced search, select a number of item types and search
3. Save the search
4. Enter a search term (such as power)
5. select the filter. Observe the following message:
Error: Unable to understand your search query, please rephrase and try again.
6. Apply patch
7. Repeat steps 4 & 5, search should work as expected.
8. Sign off!

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2025-02-10 13:11:15 UTC
Created attachment 177690 [details] [review]
Bug 39020: Add tests

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Lisette Scheer 2025-02-12 17:55:28 UTC
Created attachment 177956 [details] [review]
Bug 39020: Search filters can't parse query

Rebased after 38664

1. Turn on the SavedSearchFilters system preference
2. Go to advanced search, select a number of item types and search
3. Save the search
4. Enter a search term (such as power)
5. select the filter. Observe the following message:
Error: Unable to understand your search query, please rephrase and try again.
6. Apply patch
7. Repeat steps 4 & 5, search should work as expected.
8. Sign off!

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Katrin Fischer 2025-02-13 15:13:45 UTC
Lisette, can you please have another look here? I think you missed the second patch in your rebase! Thanks!

(Doesn't apply cleanly for me on a branch pre-tidy)
Comment 7 Lisette Scheer 2025-02-13 18:11:33 UTC
Created attachment 178042 [details] [review]
Bug 39020: Add tests

Rebased
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Katrin Fischer 2025-02-17 14:01:16 UTC
Had to tidy the file as QA script was failing?
Comment 9 Katrin Fischer 2025-02-17 14:07:17 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 10 Eric Swenson 2025-02-20 17:38:13 UTC
Would it be possible to have this backported to 24.11?