Hey everyone, I ran into a small issue with the CookieConsent system in Koha. If you forget to accept Koha’s consent cookies on a computer, the CookieConsentBar message shows up on every printed slip from that computer. The behaviour affect 24.05+ and main. Steps to reproduce: Before testing, make sure: - set the CookieConsent system preference to enable - set a CookieConsentBar message (configured in HTML personnalisations > Additional content > CookieConsentBar) Test plan: 1. Open a different web browser that hasn’t accepted Koha’s cookies yet. 2. Log into the staff interface (do not accept cookies yet). 3. Find a patron account. 4. Click on "Print" and choose any slip. 5. Check the printed slip. ---> Koha is printing the CookieConsentBar message at the bottom, which shouldn’t be there. 6. Now, accept the cookies at the bottom of the screen. 7. Print another slip. 8. Check the new slip. ---> This time, the CookieConsentBar message is gone (as expected).
Created attachment 177557 [details] [review] Bug 39035: CookieConsentBar message prints on slip when cookies aren’t accepted I added a print media query in moremember-print.tt to avoid displaying the cookies when printing a slip. Before testing, make sure: - set the CookieConsent system preference to enable - set a CookieConsentBar message (configured in HTML personnalisations > Additional content > CookieConsentBar) Test plan: 1. Open a different web browser that hasn’t accepted Koha’s cookies yet. 2. Log into the staff interface (do not accept cookies yet). 3. Find a patron account. 4. Click on "Print" and choose any slip. 5. Check the printed slip. ---> Koha is printing the CookieConsentBar message at the bottom, which shouldn’t be there. 6. Now, accept the cookies at the bottom of the screen. 7. Print another slip. 8. Check the new slip. ---> This time, the CookieConsentBar message is gone (as expected).
Could you please put this change in print.css instead? Even if the problem has only been spotted with slips I think it's a change that should be made globally.
Created attachment 177570 [details] [review] Bug 39035: Adding print media query to hide CookieConsentBar Hi Owen, You're right, thank you for the feedback. I have updated the patch and the test plan. Test plan: 1. Set the CookieConsent system preference to enable 2. Set a CookieConsentBar message (configured in HTML personnalisations > Additional content > CookieConsentBar) 3. Open a different web browser that hasn’t accepted Koha’s cookies yet. 4. Log into the staff interface (do not accept cookies yet). 5. Find a patron account. 6. Click on "Print" and choose any slip. 7. Check the printed slip. ---> Koha is printing the CookieConsentBar message at the bottom, which shouldn’t be there. 8. Apply the patch 9. Print another slip. 10. Check the new slip. ---> This time, the CookieConsentBar message is gone (as expected).
Created attachment 177650 [details] [review] Bug 39035: Adding print media query to hide cookie permissions Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Shouldnt this be a bug ?
Created attachment 178698 [details] [review] Bug 39035: Adding print media query to hide cookie permissions Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
PQA but we should file another bug to do this same treatment to the OPAC.
Pushed for 25.05! Well done everyone, thank you!