I'd like to make a few improvements to the style of buttons in the various stages of building a guided report
Created attachment 177535 [details] [review] Bug 39043: Style improvement to guided reports controls This patch makes some markup and CSS changes to improve the style of controls in the build guided report process. To test, apply the patch and rebuild the staff interface CSS. - Go to Reports -> Create guided report - In each step of the process, confirm that navigation buttons are styled with Font Awesome arrow icons. - In step 3, confirm that the "Add" and "Delete" buttons are well-styled and aligned well between the two selection boxes. Sponsored-by: Athens County Public Libraries
Created attachment 177950 [details] [review] Bug 39043: Style improvement to guided reports controls This patch makes some markup and CSS changes to improve the style of controls in the build guided report process. To test, apply the patch and rebuild the staff interface CSS. - Go to Reports -> Create guided report - In each step of the process, confirm that navigation buttons are styled with Font Awesome arrow icons. - In step 3, confirm that the "Add" and "Delete" buttons are well-styled and aligned well between the two selection boxes. Sponsored-by: Athens County Public Libraries
- Tested guided report before applying patch. - Applied patch and rebuilt CSS. - Confirmed that guided report now has navigation buttons with styled arrows in each step 1-5, and step 3's add and delete buttons are also styled with arrows and are well aligned. - Step 6 finish -button isn't styled with an arrow. - After clicking finish button, Confirm custom report -page has a Next button without an arrow. I don't think the lone Finish button in step 6 or Next button in Confirm custom report -page need the styled arrow, but I'm not sure if they are supposed to have the arrows or not? If not, I'd signoff the patch.
(In reply to Lauri Hänninen from comment #3) > I don't think the lone Finish button in step 6 or Next button in Confirm > custom report -page need the styled arrow This makes me think that the "Finish" button should probably be relabeled "Next ->" and the button on the next page relabeled "Finish".
So this patch isn't NSO anymore ? Maybe waiting Lauri's feedback fix ?
(In reply to Owen Leonard from comment #4) > (In reply to Lauri Hänninen from comment #3) > > I don't think the lone Finish button in step 6 or Next button in Confirm > > custom report -page need the styled arrow > > This makes me think that the "Finish" button should probably be relabeled > "Next ->" and the button on the next page relabeled "Finish". I agree here that this would make more sense.
Another point of confusion is the text "You will need to save the report before you can execute it". That's not true... The report is saved without a title whether or not you update it in the next step. "You may add a title to your report in the next step" ? Should the "Confirm custom report" page be step 7 of 7 rather than the un-numbered step after step 6?
Created attachment 180692 [details] [review] Bug 39043: Style improvement to guided reports controls This patch makes some markup and CSS changes to improve the style of controls in the build guided report process. To test, apply the patch and rebuild the staff interface CSS. - Go to Reports -> Create guided report - In each step of the process, confirm that navigation buttons are styled with Font Awesome arrow icons. - In step 3, confirm that the "Add" and "Delete" buttons are well-styled and aligned well between the two selection boxes. Sponsored-by: Athens County Public Libraries
Created attachment 180693 [details] [review] Bug 39043: (follow-up) Re-number the steps, add back button to more steps
Created attachment 180708 [details] [review] Bug 39043: Style improvement to guided reports controls This patch makes some markup and CSS changes to improve the style of controls in the build guided report process. To test, apply the patch and rebuild the staff interface CSS. - Go to Reports -> Create guided report - In each step of the process, confirm that navigation buttons are styled with Font Awesome arrow icons. - In step 3, confirm that the "Add" and "Delete" buttons are well-styled and aligned well between the two selection boxes. Sponsored-by: Athens County Public Libraries Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 180709 [details] [review] Bug 39043: (follow-up) Re-number the steps, add back button to more steps Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>