Bug 39043 - Style improvement to guided reports controls
Summary: Style improvement to guided reports controls
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-05 16:28 UTC by Owen Leonard
Modified: 2025-04-07 21:04 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39043: Style improvement to guided reports controls (12.18 KB, patch)
2025-02-05 17:21 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39043: Style improvement to guided reports controls (11.99 KB, patch)
2025-02-12 17:13 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39043: Style improvement to guided reports controls (11.99 KB, patch)
2025-04-07 12:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39043: (follow-up) Re-number the steps, add back button to more steps (13.69 KB, patch)
2025-04-07 12:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39043: Style improvement to guided reports controls (12.05 KB, patch)
2025-04-07 21:04 UTC, Brendan Gallagher
Details | Diff | Splinter Review
Bug 39043: (follow-up) Re-number the steps, add back button to more steps (13.75 KB, patch)
2025-04-07 21:04 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-02-05 16:28:15 UTC
I'd like to make a few improvements to the style of buttons in the various stages of building a guided report
Comment 1 Owen Leonard 2025-02-05 17:21:14 UTC
Created attachment 177535 [details] [review]
Bug 39043: Style improvement to guided reports controls

This patch makes some markup and CSS changes to improve the style of
controls in the build guided report process.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Reports -> Create guided report
- In each step of the process, confirm that navigation buttons are
  styled with Font Awesome arrow icons.
  - In step 3, confirm that the "Add" and "Delete" buttons are
    well-styled and aligned well between the two selection boxes.

Sponsored-by: Athens County Public Libraries
Comment 2 Owen Leonard 2025-02-12 17:13:05 UTC
Created attachment 177950 [details] [review]
Bug 39043: Style improvement to guided reports controls

This patch makes some markup and CSS changes to improve the style of
controls in the build guided report process.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Reports -> Create guided report
- In each step of the process, confirm that navigation buttons are
  styled with Font Awesome arrow icons.
  - In step 3, confirm that the "Add" and "Delete" buttons are
    well-styled and aligned well between the two selection boxes.

Sponsored-by: Athens County Public Libraries
Comment 3 Lauri Hänninen 2025-02-21 12:23:12 UTC
- Tested guided report before applying patch.
- Applied patch and rebuilt CSS.
- Confirmed that guided report now has navigation buttons with styled arrows in each step 1-5, and step 3's add and delete buttons are also styled with arrows and are well aligned. 
- Step 6 finish -button isn't styled with an arrow.
- After clicking finish button, Confirm custom report -page has a Next button without an arrow.

I don't think the lone Finish button in step 6 or Next button in Confirm custom report -page need the styled arrow, but I'm not sure if they are supposed to have the arrows or not? If not, I'd signoff the patch.
Comment 4 Owen Leonard 2025-02-21 15:10:58 UTC
(In reply to Lauri Hänninen from comment #3)
> I don't think the lone Finish button in step 6 or Next button in Confirm
> custom report -page need the styled arrow

This makes me think that the "Finish" button should probably be relabeled "Next ->" and the button on the next page relabeled "Finish".
Comment 5 claire.hernandez@biblibre.com 2025-04-02 13:42:22 UTC
So this patch isn't NSO anymore ?
Maybe waiting Lauri's feedback fix ?
Comment 6 Lauri Hänninen 2025-04-02 14:03:52 UTC
(In reply to Owen Leonard from comment #4)
> (In reply to Lauri Hänninen from comment #3)
> > I don't think the lone Finish button in step 6 or Next button in Confirm
> > custom report -page need the styled arrow
> 
> This makes me think that the "Finish" button should probably be relabeled
> "Next ->" and the button on the next page relabeled "Finish".

I agree here that this would make more sense.
Comment 7 Owen Leonard 2025-04-02 14:40:03 UTC
Another point of confusion is the text "You will need to save the report before you can execute it". That's not true... The report is saved without a title whether or not you update it in the next step.

"You may add a title to your report in the next step" ?

Should the "Confirm custom report" page be step 7 of 7 rather than the un-numbered step after step 6?
Comment 8 Owen Leonard 2025-04-07 12:10:42 UTC
Created attachment 180692 [details] [review]
Bug 39043: Style improvement to guided reports controls

This patch makes some markup and CSS changes to improve the style of
controls in the build guided report process.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Reports -> Create guided report
- In each step of the process, confirm that navigation buttons are
  styled with Font Awesome arrow icons.
  - In step 3, confirm that the "Add" and "Delete" buttons are
    well-styled and aligned well between the two selection boxes.

Sponsored-by: Athens County Public Libraries
Comment 9 Owen Leonard 2025-04-07 12:10:44 UTC
Created attachment 180693 [details] [review]
Bug 39043: (follow-up) Re-number the steps, add back button to more steps
Comment 10 Brendan Gallagher 2025-04-07 21:04:41 UTC
Created attachment 180708 [details] [review]
Bug 39043: Style improvement to guided reports controls

This patch makes some markup and CSS changes to improve the style of
controls in the build guided report process.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Reports -> Create guided report
- In each step of the process, confirm that navigation buttons are
  styled with Font Awesome arrow icons.
  - In step 3, confirm that the "Add" and "Delete" buttons are
    well-styled and aligned well between the two selection boxes.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 11 Brendan Gallagher 2025-04-07 21:04:43 UTC
Created attachment 180709 [details] [review]
Bug 39043: (follow-up) Re-number the steps, add back button to more steps

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>