Created attachment 177552 [details] Screenshot showing the proposed updated page On the transfers to receive page we color the whole row red if the transfer is late. I think it would be more user-friendly to style the date-late information with a Bootstrap badge instead.
Created attachment 177585 [details] [review] Bug 39046: Use Bootstrap badge to indicate late transfers This patch removes the error class from the table of late transfers. Instead, the days late status is shown as a Bootstrap badge. The patch also adds pluralization to the string so that it adapts based on the number of late transfers. To test you would ideally have multiple pending transfers to your library, some late and some not. This will presumably require manually updated your database to change the date of pending transfers. - Make at least one transfer multiple days late by changing the `datesent` value to a date late enough to exceed the number of days defined in the TransfersMaxDaysWarning system preference. - Make at least one transfer only one day late. - When you go to Circulation -> Transfers to receive you should see badge-style labels on the transfers which are late. - The text of the labels should be correct according to the number: "1 day late" or "XX days late" Sponsored-by: Athens County Public Libraries
Created attachment 177949 [details] [review] Bug 39046: Use Bootstrap badge to indicate late transfers This patch removes the error class from the table of late transfers. Instead, the days late status is shown as a Bootstrap badge. The patch also adds pluralization to the string so that it adapts based on the number of late transfers. To test you would ideally have multiple pending transfers to your library, some late and some not. This will presumably require manually updated your database to change the date of pending transfers. - Make at least one transfer multiple days late by changing the `datesent` value to a date late enough to exceed the number of days defined in the TransfersMaxDaysWarning system preference. - Make at least one transfer only one day late. - When you go to Circulation -> Transfers to receive you should see badge-style labels on the transfers which are late. - The text of the labels should be correct according to the number: "1 day late" or "XX days late" Sponsored-by: Athens County Public Libraries
Is it directly related to bug 38664? (or it's dependencies that did cleanup) Or is the "Depends on 38664" just because it's a patch that can only directly be applied on top of 38664? (as likely most new patches)
(In reply to Victor Grousset/tuxayo from comment #3) > Or is the "Depends on 38664" just because it's a patch that can only > directly be applied on top of 38664? I was working on this patch before 38664 was pushed, so the dependency was necessary at the time. Now it's not relevant.
Created attachment 178479 [details] [review] Bug 39046: Use Bootstrap badge to indicate late transfers This patch removes the error class from the table of late transfers. Instead, the days late status is shown as a Bootstrap badge. The patch also adds pluralization to the string so that it adapts based on the number of late transfers. To test you would ideally have multiple pending transfers to your library, some late and some not. This will presumably require manually updated your database to change the date of pending transfers. - Make at least one transfer multiple days late by changing the `datesent` value to a date late enough to exceed the number of days defined in the TransfersMaxDaysWarning system preference. - Make at least one transfer only one day late. - When you go to Circulation -> Transfers to receive you should see badge-style labels on the transfers which are late. - The text of the labels should be correct according to the number: "1 day late" or "XX days late" Sponsored-by: Athens County Public Libraries Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
A small notice: Above the table of transfers is the info text that says "Transfers are considered late after x days.". In this sentence the words "considered late" are red which implies that something is colored red underneath, which no longer applies after this change. I think this is not a show stopper but could be fixed sometimes.
Created attachment 180849 [details] [review] Bug 39046: Use Bootstrap badge to indicate late transfers This patch removes the error class from the table of late transfers. Instead, the days late status is shown as a Bootstrap badge. The patch also adds pluralization to the string so that it adapts based on the number of late transfers. To test you would ideally have multiple pending transfers to your library, some late and some not. This will presumably require manually updated your database to change the date of pending transfers. - Make at least one transfer multiple days late by changing the `datesent` value to a date late enough to exceed the number of days defined in the TransfersMaxDaysWarning system preference. - Make at least one transfer only one day late. - When you go to Circulation -> Transfers to receive you should see badge-style labels on the transfers which are late. - The text of the labels should be correct according to the number: "1 day late" or "XX days late" Sponsored-by: Athens County Public Libraries Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
I love these QoL patches :) Passes QA, very small and clean