Bug 39051 - Cash register statistics form submit button styled incorrectly
Summary: Cash register statistics form submit button styled incorrectly
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Nick Clemens (kidclamp)
URL:
Keywords:
Depends on: 32091
Blocks:
  Show dependency treegraph
 
Reported: 2025-02-06 13:42 UTC by Owen Leonard
Modified: 2025-02-13 15:20 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39051: Fix submit button class on cash register statistics page (1.33 KB, patch)
2025-02-06 13:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39051: Fix submit button class on cash register statistics page (1.40 KB, patch)
2025-02-07 07:12 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 39051: Fix submit button class on cash register statistics page (1.46 KB, patch)
2025-02-07 14:52 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 39051: Fix submit button class on cash register statistics page (1.46 KB, patch)
2025-02-12 17:19 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-02-06 13:42:27 UTC
Submit buttons should have the "btn-primary" class instead of "btn-default"
Comment 1 Owen Leonard 2025-02-06 13:48:02 UTC
Created attachment 177572 [details] [review]
Bug 39051: Fix submit button class on cash register statistics page

This patch corrects the class of the submit button on the cash register
statistics page. Bug 32091 added the "btn btn-default" class but it
should have been "btn-default."

To test, apply the patch and go to Reports -> Cash register statistics.

The submit button should have the yellow "primary" button color.

Sponsored-by: Athens County Public Libraries
Comment 2 Magnus Enger 2025-02-07 07:12:33 UTC
Created attachment 177610 [details] [review]
Bug 39051: Fix submit button class on cash register statistics page

This patch corrects the class of the submit button on the cash register
statistics page. Bug 32091 added the "btn btn-default" class but it
should have been "btn-default."

To test, apply the patch and go to Reports -> Cash register statistics.

The submit button should have the yellow "primary" button color.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Button is now yellow.
Comment 3 Nick Clemens (kidclamp) 2025-02-07 14:52:58 UTC
Created attachment 177632 [details] [review]
Bug 39051: Fix submit button class on cash register statistics page

This patch corrects the class of the submit button on the cash register
statistics page. Bug 32091 added the "btn btn-default" class but it
should have been "btn-default."

To test, apply the patch and go to Reports -> Cash register statistics.

The submit button should have the yellow "primary" button color.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Button is now yellow.
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Owen Leonard 2025-02-12 17:19:16 UTC
Created attachment 177951 [details] [review]
Bug 39051: Fix submit button class on cash register statistics page

This patch corrects the class of the submit button on the cash register
statistics page. Bug 32091 added the "btn btn-default" class but it
should have been "btn-default."

To test, apply the patch and go to Reports -> Cash register statistics.

The submit button should have the yellow "primary" button color.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Button is now yellow.
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Katrin Fischer 2025-02-13 15:20:40 UTC
Pushed for 25.05!

Well done everyone, thank you!