When using the Duplicate button from a patron's record, we make a new patron with some of the original patron's info. We bring the surname to the new patron, but not the firstname. Following that logic, we shouldn't copy preferred_name, either. Currently on main the preferred_name *is* copied to the new patron. In the long run this probably wants something like the PrefillGuaranteeField syspref, but in the short term we should just exclude preferred_name.
Created attachment 177592 [details] [review] Bug 39056: Do not copy preferred_name to new patron when using Duplicate It looks like this was a type/copy paste error, template fixed To test: 1 - Find a patron, ensure preferred_name is populated 2 - Duplicate 3 - Note preferred_name is carried over 4 - Apply patch 5 - Cancel and duplicate again 6 - Preferred name is blank!
Created attachment 177594 [details] [review] Bug 39056: Do not copy preferred_name to new patron when using Duplicate It looks like this was a type/copy paste error, template fixed To test: 1 - Find a patron, ensure preferred_name is populated 2 - Duplicate 3 - Note preferred_name is carried over 4 - Apply patch 5 - Cancel and duplicate again 6 - Preferred name is blank! Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Created attachment 177637 [details] [review] Bug 39056: Do not copy preferred_name to new patron when using Duplicate It looks like this was a type/copy paste error, template fixed To test: 1 - Find a patron, ensure preferred_name is populated 2 - Duplicate 3 - Note preferred_name is carried over 4 - Apply patch 5 - Cancel and duplicate again 6 - Preferred name is blank! Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Good catch, thanks all! Passing QA
Created attachment 177916 [details] [review] Bug 39056: Do not copy preferred_name to new patron when using Duplicate It looks like this was a type/copy paste error, template fixed To test: 1 - Find a patron, ensure preferred_name is populated 2 - Duplicate 3 - Note preferred_name is carried over 4 - Apply patch 5 - Cancel and duplicate again 6 - Preferred name is blank! Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Good catch!
Pushed for 25.05! Well done everyone, thank you!