Bug 39056 - Do not copy preferred_name to new patron when using Duplicate
Summary: Do not copy preferred_name to new patron when using Duplicate
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-06 18:12 UTC by Andrew Fuerste-Henry
Modified: 2025-02-12 14:29 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39056: Do not copy preferred_name to new patron when using Duplicate (1.87 KB, patch)
2025-02-06 19:28 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 39056: Do not copy preferred_name to new patron when using Duplicate (1.93 KB, patch)
2025-02-06 19:45 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 39056: Do not copy preferred_name to new patron when using Duplicate (2.00 KB, patch)
2025-02-07 15:54 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 39056: Do not copy preferred_name to new patron when using Duplicate (2.02 KB, patch)
2025-02-12 14:08 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2025-02-06 18:12:36 UTC
When using the Duplicate button from a patron's record, we make a new patron with some of the original patron's info. We bring the surname to the new patron, but not the firstname. Following that logic, we shouldn't copy preferred_name, either. Currently on main the preferred_name *is* copied to the new patron. 

In the long run this probably wants something like the PrefillGuaranteeField syspref, but in the short term we should just exclude preferred_name.
Comment 1 Nick Clemens (kidclamp) 2025-02-06 19:28:16 UTC
Created attachment 177592 [details] [review]
Bug 39056: Do not copy preferred_name to new patron when using Duplicate

It looks like this was a type/copy paste error, template fixed

To test:
1 - Find a patron, ensure preferred_name is populated
2 - Duplicate
3 - Note preferred_name is carried over
4 - Apply patch
5 - Cancel and duplicate again
6 - Preferred name is blank!
Comment 2 Andrew Fuerste-Henry 2025-02-06 19:45:36 UTC
Created attachment 177594 [details] [review]
Bug 39056: Do not copy preferred_name to new patron when using Duplicate

It looks like this was a type/copy paste error, template fixed

To test:
1 - Find a patron, ensure preferred_name is populated
2 - Duplicate
3 - Note preferred_name is carried over
4 - Apply patch
5 - Cancel and duplicate again
6 - Preferred name is blank!

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Comment 3 Emily Lamancusa (emlam) 2025-02-07 15:54:05 UTC
Created attachment 177637 [details] [review]
Bug 39056: Do not copy preferred_name to new patron when using Duplicate

It looks like this was a type/copy paste error, template fixed

To test:
1 - Find a patron, ensure preferred_name is populated
2 - Duplicate
3 - Note preferred_name is carried over
4 - Apply patch
5 - Cancel and duplicate again
6 - Preferred name is blank!

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Emily Lamancusa (emlam) 2025-02-07 15:54:31 UTC
Good catch, thanks all! Passing QA
Comment 5 Jonathan Druart 2025-02-12 14:08:43 UTC
Created attachment 177916 [details] [review]
Bug 39056: Do not copy preferred_name to new patron when using Duplicate

It looks like this was a type/copy paste error, template fixed

To test:
1 - Find a patron, ensure preferred_name is populated
2 - Duplicate
3 - Note preferred_name is carried over
4 - Apply patch
5 - Cancel and duplicate again
6 - Preferred name is blank!

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 6 Katrin Fischer 2025-02-12 14:15:11 UTC
Good catch!
Comment 7 Katrin Fischer 2025-02-12 14:29:05 UTC
Pushed for 25.05!

Well done everyone, thank you!