items.stocknumber (labeled as Inventory Number, 952$i, in edit interface) is a field that many libraries use to hold an idiosyncratic bit of local data. For such libraries, the 32 character limit can be an issue. If there's a compelling reason not to increase the size of this field, I haven't thought of or found it.
Created attachment 177602 [details] [review] Bug 39062: increase length of items.stocknumber and deleteditems.stocknumber in kohastructure.sql To test: 1: try to save a value in the 952$i that is more than 32 characters 2: It does not work. 3: apply patch 4: try to save a value in the 952$i that is more than 32 characters 5: it does work! 6: delete your item and use a report to confirm the full string is in deleteditems.stocknumber 7: Maybe use DESCRIBE from mysql commandline to see the length and confirm it's changed?
Created attachment 177603 [details] [review] Bug 39062: Increase stocknumber length in items and deleteditems
Created attachment 177604 [details] [review] Bug 39062: Increase stocknumber length in items and deleteditems But this time I spelled deleted correctly.
At a glance, I think you've accidentally obsoleted a patch you shouldn't have. I'll try to restore that...
Created attachment 177697 [details] [review] Bug 39062: increase length of items.stocknumber and deleteditems.stocknumber in kohastructure.sql To test: 1: try to save a value in the 952$i that is more than 32 characters 2: It does not work. 3: apply patch 4: try to save a value in the 952$i that is more than 32 characters 5: it does work! 6: delete your item and use a report to confirm the full string is in deleteditems.stocknumber 7: Maybe use DESCRIBE from mysql commandline to see the length and confirm it's changed?
Created attachment 177698 [details] [review] Bug 39062: Increase stocknumber length in items and deleteditems
(In reply to David Cook from comment #4) > At a glance, I think you've accidentally obsoleted a patch you shouldn't > have. I'll try to restore that... Thanks, I think I've successfully fixed those into one patch!
(In reply to Andrew Fuerste-Henry from comment #7) > (In reply to David Cook from comment #4) > > At a glance, I think you've accidentally obsoleted a patch you shouldn't > > have. I'll try to restore that... > > Thanks, I think I've successfully fixed those into one patch! Looks good!
The test report should probably mentioning needing to update the database in addition to applying the patch, but all good...
QA tools complaining about tidiness but I think we're not caring about that anymore... WARN installer/data/mysql/atomicupdate/bug_39062_increase_stocknumber_length.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 2) OK installer/data/mysql/kohastructure.sql
Created attachment 177716 [details] [review] Bug 39062: increase length of items.stocknumber and deleteditems.stocknumber in kohastructure.sql To test: 1: try to save a value in the 952$i that is more than 32 characters 2: It does not work. 3: apply patch 4: try to save a value in the 952$i that is more than 32 characters 5: it does work! 6: delete your item and use a report to confirm the full string is in deleteditems.stocknumber 7: Maybe use DESCRIBE from mysql commandline to see the length and confirm it's changed? Signed-off-by: David Cook <dcook@prosentient.com.au>
Created attachment 177717 [details] [review] Bug 39062: Increase stocknumber length in items and deleteditems Signed-off-by: David Cook <dcook@prosentient.com.au>
FAIL installer/data/mysql/atomicupdate/bug_39062_increase_stocknumber_length.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl installer/data/mysql/atomicupdate/bug_39062_increase_stocknumber_length.pl`
Created attachment 179114 [details] [review] Bug 39062: (QA follow-up): Tidying the atomic update