Bug 39077 - Translation script raises warnings for obsolete translations
Summary: Translation script raises warnings for obsolete translations
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Tomás Cohen Arazi (tcohen)
URL:
Keywords:
: 37068 (view as bug list)
Depends on:
Blocks:
 
Reported: 2025-02-10 14:17 UTC by Jonathan Druart
Modified: 2025-04-17 12:46 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00,24.11.04
Circulation function:


Attachments
Bug 39077: Do not complain about obsolete translations (1.19 KB, patch)
2025-02-10 14:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39077: Do not complain about obsolete translations (1.25 KB, patch)
2025-02-10 14:42 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-02-10 14:17:06 UTC
es-ES has commented/obsolete translations with "unconsistent %s count".

The strings cannot be fixed in Weblate, and so the koha-translate script will always raise a warning about those strings.

We should not complain about obsolete translations.
Comment 1 Jonathan Druart 2025-02-10 14:17:41 UTC
Created attachment 177696 [details] [review]
Bug 39077: Do not complain about obsolete translations
Comment 2 Jonathan Druart 2025-02-10 14:20:11 UTC
Test plan:
Update the po files before you apply this patch for es-ES

koha-translate --update es-ES --dev kohadev

=> Notice the warnings

Apply this patch

Translate again

=> No warnings.
Comment 3 Tomás Cohen Arazi (tcohen) 2025-02-10 14:42:35 UTC
Created attachment 177699 [details] [review]
Bug 39077: Do not complain about obsolete translations

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi (tcohen) 2025-02-10 14:44:22 UTC
Tested it. Works as described. Adding that the 'update po files before' step requires:

```shell
cd misc/translator/po
git fech
git reset --hard origin/main
```

Nice work.
Comment 5 Katrin Fischer 2025-02-13 14:32:45 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 6 Jonathan Druart 2025-03-26 04:51:13 UTC
*** Bug 37068 has been marked as a duplicate of this bug. ***
Comment 7 Paul Derscheid 2025-04-17 12:45:45 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.04