Bug 39080 - Table headers of holds to pull table are incorrect size on scroll
Summary: Table headers of holds to pull table are incorrect size on scroll
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 36640
Blocks:
  Show dependency treegraph
 
Reported: 2025-02-10 18:16 UTC by Lisette Scheer
Modified: 2025-02-17 14:07 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
title example (219.83 KB, image/png)
2025-02-10 18:16 UTC, Lisette Scheer
Details
Bug 39080: Redraw the table after we added the column filters (1.30 KB, patch)
2025-02-11 09:29 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39080: Adjust the fixed header after we added the column filters (1.19 KB, patch)
2025-02-11 13:06 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39080: Adjust the fixed header after we added the column filters (1.24 KB, patch)
2025-02-13 21:51 UTC, David Nind
Details | Diff | Splinter Review
Bug 39080: Adjust the fixed header after we added the column filters (1.33 KB, patch)
2025-02-14 08:08 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lisette Scheer 2025-02-10 18:16:53 UTC
Created attachment 177707 [details]
title example

After the datatable updates the header of the "title" column doesn't keep the correct width when you scroll down, so everything is off that's to the right of it.
Comment 1 Jonathan Druart 2025-02-11 09:29:36 UTC
Created attachment 177726 [details] [review]
Bug 39080: Redraw the table after we added the column filters

If a column contains a dropdown list (for libraries for instance), the
width of the column will be modified, but DT won't redraw the table and
the offset will be kept on horizontal scroll.

Test plan:
One example where this problem can be observed is the "holds to pull"
table: "Title" is followed by "Libraries".
Test without and with the patch, and confirm that the display/offset is fixed.
Comment 2 Owen Leonard 2025-02-11 12:45:34 UTC
This is not working for me. I still get the alignment problem. Curiously, if I hide or show a column using the columns dropdown the alignment is fixed.
Comment 3 Jonathan Druart 2025-02-11 13:06:47 UTC
Created attachment 177730 [details] [review]
Bug 39080: Adjust the fixed header after we added the column filters

If a column contains a dropdown list (for libraries for instance), the
width of the column will be modified, but DT's fixed header need to be
adjusted.

Test plan:
One example where this problem can be observed is the "holds to pull"
table: "Title" is followed by "Libraries".
Test without and with the patch, and confirm that the display/offset is fixed.
Comment 4 Jonathan Druart 2025-02-11 13:07:14 UTC
Hum indeed. I didn't understand why the patch was fixing the problem. I certainly have tested incorrectly!

I think this second patch is fixing the problem correctly.
Comment 5 David Nind 2025-02-13 21:51:37 UTC
Created attachment 178054 [details] [review]
Bug 39080: Adjust the fixed header after we added the column filters

If a column contains a dropdown list (for libraries for instance), the
width of the column will be modified, but DT's fixed header need to be
adjusted.

Test plan:
One example where this problem can be observed is the "holds to pull"
table: "Title" is followed by "Libraries".
Test without and with the patch, and confirm that the display/offset is fixed.

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Marcel de Rooy 2025-02-14 08:08:14 UTC
Created attachment 178078 [details] [review]
Bug 39080: Adjust the fixed header after we added the column filters

If a column contains a dropdown list (for libraries for instance), the
width of the column will be modified, but DT's fixed header need to be
adjusted.

Test plan:
One example where this problem can be observed is the "holds to pull"
table: "Title" is followed by "Libraries".
Test without and with the patch, and confirm that the display/offset is fixed.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Katrin Fischer 2025-02-17 14:07:28 UTC
Pushed for 25.05!

Well done everyone, thank you!