Created attachment 177707 [details] title example After the datatable updates the header of the "title" column doesn't keep the correct width when you scroll down, so everything is off that's to the right of it.
Created attachment 177726 [details] [review] Bug 39080: Redraw the table after we added the column filters If a column contains a dropdown list (for libraries for instance), the width of the column will be modified, but DT won't redraw the table and the offset will be kept on horizontal scroll. Test plan: One example where this problem can be observed is the "holds to pull" table: "Title" is followed by "Libraries". Test without and with the patch, and confirm that the display/offset is fixed.
This is not working for me. I still get the alignment problem. Curiously, if I hide or show a column using the columns dropdown the alignment is fixed.
Created attachment 177730 [details] [review] Bug 39080: Adjust the fixed header after we added the column filters If a column contains a dropdown list (for libraries for instance), the width of the column will be modified, but DT's fixed header need to be adjusted. Test plan: One example where this problem can be observed is the "holds to pull" table: "Title" is followed by "Libraries". Test without and with the patch, and confirm that the display/offset is fixed.
Hum indeed. I didn't understand why the patch was fixing the problem. I certainly have tested incorrectly! I think this second patch is fixing the problem correctly.
Created attachment 178054 [details] [review] Bug 39080: Adjust the fixed header after we added the column filters If a column contains a dropdown list (for libraries for instance), the width of the column will be modified, but DT's fixed header need to be adjusted. Test plan: One example where this problem can be observed is the "holds to pull" table: "Title" is followed by "Libraries". Test without and with the patch, and confirm that the display/offset is fixed. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 178078 [details] [review] Bug 39080: Adjust the fixed header after we added the column filters If a column contains a dropdown list (for libraries for instance), the width of the column will be modified, but DT's fixed header need to be adjusted. Test plan: One example where this problem can be observed is the "holds to pull" table: "Title" is followed by "Libraries". Test without and with the patch, and confirm that the display/offset is fixed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 25.05! Well done everyone, thank you!